Skip to content

Commit

Permalink
fix uninitialized values (#330)
Browse files Browse the repository at this point in the history
Unfortunately #324 missed to add the initialization of the new component
of `numIALeft` which led to non-reproducible results as soon the the
circular buffer got around, found in a long discussion with @hahnjo.

To Do:
- [x] general physics validation
- [x] physics validation for alllayers, regions, noregions
- [x] ensure reproducibility in ttbar events
 
 Validation: 
`setTrackInAllRegions`:
![Screenshot from 2025-01-09
14-42-21](https://github.com/user-attachments/assets/cadf4a65-2b1d-43dd-abbe-96199b1845ae)

`alllayers`:
![Screenshot from 2025-01-09
16-29-33](https://github.com/user-attachments/assets/c9725eb1-a7ff-4858-88a5-4338cc7c4c95)

`regions`:
![Screenshot from 2025-01-09
16-30-09](https://github.com/user-attachments/assets/2f65f97e-3eea-47e6-a715-2702a45b8e76)

`noregions`
![Screenshot from 2025-01-09
16-30-36](https://github.com/user-attachments/assets/54f9e467-c3c2-430b-ae97-0a8438ca118a)
  • Loading branch information
SeverinDiederichs authored Jan 9, 2025
1 parent b17501a commit 9697480
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions include/AdePT/core/AdePTTransport.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ __global__ void InitTracks(adeptint::TrackData *trackinfo, int ntracks, int star
track.numIALeft[0] = -1.0;
track.numIALeft[1] = -1.0;
track.numIALeft[2] = -1.0;
track.numIALeft[3] = -1.0;

track.initialRange = -1.0;
track.dynamicRangeFactor = -1.0;
Expand Down
1 change: 1 addition & 0 deletions include/AdePT/core/Track.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ struct Track {
this->numIALeft[0] = -1.0;
this->numIALeft[1] = -1.0;
this->numIALeft[2] = -1.0;
this->numIALeft[3] = -1.0;

this->initialRange = -1.0;
this->dynamicRangeFactor = -1.0;
Expand Down

0 comments on commit 9697480

Please sign in to comment.