use new table virtualization #2033
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the pink-svelte and pink-icons-svelte dependencies to new versions and refactors the collection table to use the new virtualized table component for improved performance.
|
The preview deployment failed. 🔴 Last updated at: 2025-06-18 13:57:17 CET |
|
The preview deployment failed. 🔴 Last updated at: 2025-06-18 13:57:10 CET |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades dependencies and refactors the collection table to use the new virtualized table component for improved rendering performance.
- Updated
pink-sveltedependency source and bumpedpink-icons-svelte - Swapped out the legacy
Table.RootforTable.VirtualRootintable.svelte - Centralized column definitions and visibility logic in
+page.svelte
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/(console)/…/collection-[collection]/table.svelte | Replaced non-virtualized table with Table.VirtualRoot and associated cell loops |
| src/routes/(console)/…/collection-[collection]/+page.svelte | Adjusted column store initialization to include ID/created/updated columns and hide flags |
| src/lib/stores/preferences.ts | Changed default return from getCustomCollectionColumns to null instead of [] |
| src/lib/components/columnSelector.svelte | Added type annotation for containerRef and converted selectedColumnsNumber to a const derived store |
| package.json | Updated @appwrite.io/pink-svelte URL |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| </Table.VirtualCell> | ||
| {:else} | ||
| {@const id = column.id} | ||
| {@const attr = $attributes.find((n) => n.key === id)} |
There was a problem hiding this comment.
Calling .find on $attributes for every cell renders in O(n) per cell. Precompute a lookup map (e.g., {[key]: attribute}) before rendering to achieve constant-time attribute access.
Suggested change
| {@const attr = $attributes.find((n) => n.key === id)} | |
| {@const attr = attributesMap[id]} |
Copilot uses AI. Check for mistakes.
ItzNotABug
reviewed
Jun 18, 2025
...roject-[region]-[project]/databases/database-[database]/collection-[collection]/table.svelte
Show resolved
Hide resolved
ItzNotABug
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the pink-svelte and pink-icons-svelte dependencies to new versions and refactors the collection table to use the new virtualized table component for improved performance.
Bildschirmaufnahme.2025-06-18.um.11.28.25.mov