Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #51 #52

Merged
merged 10 commits into from
Apr 9, 2022
Merged

Fix #51 #52

merged 10 commits into from
Apr 9, 2022

Conversation

Toreno96
Copy link
Collaborator

@Toreno96 Toreno96 commented Apr 9, 2022

No description provided.

@Toreno96
Copy link
Collaborator Author

Toreno96 commented Apr 9, 2022

In the end, there were a few additional issues:

  1. pip 22.0.1 broke pip_shims.unpack_url pdm-project/pdm#874 resolved by upgrading the PDM's version in the CI/CD.
  2. https://results.pre-commit.ci/run/github/434866662/1649509163.TLPbkD6ATgWPb6bTABvFpw
ImportError: cannot import name '_unicodefun' from 'click' (/pc/clone/OjKGFA1sRlaKkrrCMZD1Rg/py_env-python3.10/lib/python3.10/site-packages/click/__init__.py)

Resolved by adding:

     -   id: black
+        additional_dependencies: ['click<=8.0.4']

@Toreno96
Copy link
Collaborator Author

Toreno96 commented Apr 9, 2022

I've also upgraded the pdm.lock, as there was a warning about the outdated lock, and we've done so many updates in this PR anyway that it's probably worth the risk.

@Toreno96 Toreno96 merged commit 28e099a into master Apr 9, 2022
@Toreno96 Toreno96 deleted the issue-51 branch April 9, 2022 13:59
@Toreno96 Toreno96 mentioned this pull request Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Toreno96