Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc Button implementations not using isIconButton prop #37382

Merged
merged 10 commits into from
Nov 14, 2024
Merged

fix: misc Button implementations not using isIconButton prop #37382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2df3594
Sync changes from EE excluding enterprise directory
hetunandu Nov 5, 2024
8ac2c1d
chore: Update ADS button min width
hetunandu Nov 5, 2024
eb2004c
Merge branch 'release' into chore/button-min-width
hetunandu Nov 12, 2024
9d2bac7
min width based on sizes
hetunandu Nov 12, 2024
61a0b61
Merge branch 'release' into chore/button-min-width
hetunandu Nov 13, 2024
224483d
fix create workspace icon button
hetunandu Nov 13, 2024
11fe0a6
fix: Code Editor slash command button size
hetunandu Nov 14, 2024
ac2ce4c
Merge branch 'release' into fix/code-editor-slash-button-size
hetunandu Nov 14, 2024
1ea9915
fix: other misc buttons
hetunandu Nov 14, 2024
dce8dcd
add ads component change
hetunandu Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/packages/design-system/ads/src/Documentation/components/CodeBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function CodeBlock({ code }: CodeBlockProps) {
}}
>
<Code>{code}</Code>
<Button kind="tertiary" startIcon="copy-control" />
<Button isIconButton kind="tertiary" startIcon="copy-control" />
</Wrapper>
);
}
Expand Down
1 change: 1 addition & 0 deletions app/client/src/components/editorComponents/CodeEditor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1710,6 +1710,7 @@ class CodeEditor extends Component<Props, State> {
"commands-button invisible",
!showSlashCommandButton && "!hidden",
)}
isIconButton
kind="tertiary"
onClick={() => {
const newValue =
Expand Down
2 changes: 2 additions & 0 deletions app/client/src/pages/AppViewer/Navigation/TopStacked.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export function TopStacked(props: NavigationProps) {
{tabsScrollable && (
<ScrollBtnContainer
className="left-0 scroll-arrows"
isIconButton
kind="tertiary"
onMouseDown={() => startScrolling(true)}
onMouseLeave={stopScrolling}
Expand Down Expand Up @@ -153,6 +154,7 @@ export function TopStacked(props: NavigationProps) {
{tabsScrollable && (
<ScrollBtnContainer
className="right-0 scroll-arrows"
isIconButton
kind="tertiary"
onMouseDown={() => startScrolling(false)}
onMouseLeave={stopScrolling}
Expand Down
7 changes: 6 additions & 1 deletion app/client/src/pages/Editor/CustomWidgetBuilder/Preview/Debugger/helpDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ export default function HelpDropdown(props: DebuggerLog) {
return (
<Popover>
<PopoverTrigger>
<Button kind="tertiary" size="sm" startIcon="question-line" />
<Button
isIconButton
kind="tertiary"
size="sm"
startIcon="question-line"
/>
</PopoverTrigger>
<PopoverContent className={styles.consoleItemHelpContent}>
<List
Expand Down
Loading