-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Support configurable timeout for reading request body #37301
base: release
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11741130254. |
Deploy-Preview-URL: https://ce-37301.dp.appsmith.com |
This isn't behaving as one would expect it to. Need further research into Caddy's |
The
APPSMITH_SERVER_TIMEOUT
env variable is not being used anywhere in the code today. This PR implements this env variable, by setting it to Caddy'sread_body
timeout. It defaults to 600s (10mins), and can't be set to below 10s.We're also setting a timeout for reading request headers to 5s, since the default Caddy timeout is no timeout at all. It shouldn't be longer than 5s to read the headers, in normal operations.
Automation
/test sanity
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11772289083
Commit: 2440c09
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Mon, 11 Nov 2024 05:16:13 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?