fix: Support NO_PROXY for RTS-Temporal connection

[sharat87]

The Temporal connection SDK used in RTS, uses GRPC to talk to the Temporal server. The GRPC library being used only respects the lowercase proxy env variables (http_proxy, https_proxy and no_proxy), and not the uppercase ones. They have an open issue asking for this since 2020.

However, in our entrypoint.sh, we normalize http_proxy and HTTP_PROXY, similarly for https_proxy and HTTPS_PROXY. But we're not doing this normalization for no_proxy and NO_PROXY.

This PR fixes this by doing the same normalization to no_proxy.

/test sanity

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11737259912
Commit: 310fa2c
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Fri, 08 Nov 2024 07:00:17 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Improved handling of proxy environment variables for enhanced configuration consistency.

• Bug Fixes

  • Ensured localhost and 127.0.0.1 are always included in the NO_PROXY variable for better connectivity.

[coderabbitai]

Walkthrough

The entrypoint.sh script has been updated to improve the handling of proxy environment variables. New logic synchronizes the NO_PROXY and no_proxy variables, ensuring consistency when either is set. Similar updates were made for the HTTPS_PROXY, https_proxy, HTTP_PROXY, and http_proxy variables. The script now guarantees that localhost and 127.0.0.1 are always included in the NO_PROXY variable while maintaining its existing functionalities related to environment variable initialization and database configurations.

Changes

File Path	Change Summary
deploy/docker/fs/opt/appsmith/entrypoint.sh	Enhanced proxy variable handling; synchronized NO_PROXY with no_proxy, and similar for HTTPS_PROXY, http_proxy, etc.; ensured localhost and 127.0.0.1 are included in NO_PROXY. Existing functionalities retained.

Poem

In the script where proxies play,
New logic shines, brightening the way.
NO_PROXY and friends now align,
Ensuring connections work just fine.
With localhost held in warm embrace,
Our setup's now a smoother place! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

deploy/docker/fs/opt/appsmith/entrypoint.sh (1)

28-33: Enhance comment clarity for proxy variable precedence.

The implementation looks good, but the comment could be more explicit about the precedence order.

-  # If one of NO_PROXY or no_proxy are set, copy it to the other. If both are set, prefer NO_PROXY.
+  # If both NO_PROXY and no_proxy are set, NO_PROXY takes precedence. Otherwise, copy the set value to the unset variable.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5e89aa0 and 310fa2c.

📒 Files selected for processing (1)

• deploy/docker/fs/opt/appsmith/entrypoint.sh (1 hunks)

🔇 Additional comments (1)

deploy/docker/fs/opt/appsmith/entrypoint.sh (1)

28-33: Implementation aligns well with existing proxy handling patterns.

The NO_PROXY synchronization logic is correctly implemented and follows the same pattern as HTTP_PROXY and HTTPS_PROXY handling. This ensures consistent behavior across all proxy-related environment variables.