test: udpated locator for GenetateCrud test #37000

NandanAnantharamu · 2024-10-21T17:58:31Z

Airgap test was failing because it was not able to click a particular dropdown.
EE: https://github.com/appsmithorg/appsmith-ee/pull/5412

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11457437998
Commit: 8ca5c36
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Tue, 22 Oct 2024 10:45:27 UTC

coderabbitai · 2024-10-21T17:58:40Z

Walkthrough

The changes in this pull request involve updates to the limited-tests.txt file, which specifies test cases in a Cypress testing environment, and modifications to the GeneratePageWithDB method in the DataSources class. The test specification path has been updated to reflect a focus shift from regression to smoke testing. Additionally, the selector used in the GeneratePageWithDB method has been simplified, maintaining the overall functionality while altering the internal logic.

Changes

File Path	Change Summary
app/client/cypress/limited-tests.txt	Updated test specification path from `cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js` to `cypress/e2e/Smoke/GenerateCRUD/Generate_Crud_New_Page_spec.ts`.
app/client/cypress/support/Pages/DataSources.ts	Modified the selector in the `GeneratePageWithDB` method from `p[kind="span"]` to `p`, with minor adjustments to comments and formatting.

Possibly related PRs

chore: Reorganise IDE Panels #35114: Updates the test specification in limited-tests.txt from a regression test to a smoke test, similar to this PR.
test: switch branch spec ce #35312: Modifies limited-tests.txt, changing the test specification from Fork_Template_spec.js to SwitchBranches_spec.js.
test: fix flaky inline editing 2 spec #35426: Updates limited-tests.txt by changing the test specification from Fork_Template_spec.js to Inline_editing_2_spec.js.
fix: Fixed flaky fork template test case #36200: Changes limited-tests.txt to update the test specification from Fork_Template_spec.js to Fork_Template_To_App_spec.ts.
fix: flaky mongo spec test #36220: Modifies limited-tests.txt by replacing Fork_Template_spec.js with Mongo_Spec.ts.
fix: mongo uri spec flakiness #36249: Updates limited-tests.txt, changing the test specification from Fork_Template_spec.js to MongoURI_Spec.ts.
chore: reactive migration #36227: Changes limited-tests.txt to update the test specification from Fork_Template_spec.js to JsOnLoad3_Spec.ts.
test: replace 3rd party API1 CE #36518: Modifies limited-tests.txt to replace Fork_Template_spec.js with API_Edit_spec.js.
test: udpated 3rd party api for Commandclick nav spec #36545: Updates limited-tests.txt by changing the test specification from Fork_Template_spec.js to Command_Click_Navigation_spec.js.
chore: Updated another set of third party urls #36571: Changes limited-tests.txt from Fork_Template_spec.js to Fetch_Spec.ts.
chore: removed old flags for airgap instances #36609: Modifies limited-tests.txt to change the test specification from Fork_Template_spec.js to ShareAppTests_Spec.ts.
fix: Fix shareapp case due to load issue #36627: Updates limited-tests.txt by changing the test specification from Fork_Template_spec.js to ShareAppTests_Spec.ts.
chore: fetch spec with removed third party #36636: Changes limited-tests.txt to update the test specification from Fork_Template_spec.js to Fetch_Spec.ts.
test: udpated files by removing un-used APIs #36705: Modifies limited-tests.txt by replacing Fork_Template_spec.js with Fetch_Spec.ts.

Suggested labels

ok-to-test

Suggested reviewers

ApekshaBhosale
sagar-qa007

🎉 In the land of code, where tests do thrive,
A new path is forged, keeping testing alive.
From regression to smoke, the focus now shifts,
With selectors simplified, we embrace new gifts.
So let’s celebrate changes, both big and small,
For in the world of coding, we’re conquering all! 🎈

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 69d5f49 and 1eb1079.

📒 Files selected for processing (1)

app/client/cypress/support/Pages/DataSources.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

app/client/cypress/support/Pages/DataSources.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NandanAnantharamu · 2024-10-21T17:58:53Z

/ci-test-limit

github-actions · 2024-10-21T17:59:26Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11445887167.
Cypress dashboard
PR: #37000.

github-actions · 2024-10-21T18:22:04Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11445887167.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-10-21T18:26:54Z

/ci-test-limit-count run_count=25

github-actions · 2024-10-21T18:27:28Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11446319372.
Cypress dashboard
PR: #37000.

github-actions · 2024-10-21T19:25:34Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11446319372.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 25 Total Passed: 25 Total Failed: 0 Total Skipped: 0 *****************************

test: udpated locator for GenetateCrud test

69d5f49

NandanAnantharamu requested review from ApekshaBhosale and sagar-qa007 as code owners October 21, 2024 17:58

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Oct 21, 2024

lint issues resolved

1eb1079

reverting the limited file

8ca5c36

sagar-qa007 approved these changes Oct 22, 2024

View reviewed changes

NandanAnantharamu added the ok-to-test Required label for CI label Oct 22, 2024

NandanAnantharamu merged commit a8da0e1 into release Oct 22, 2024
52 checks passed

NandanAnantharamu deleted the test/fixGenereateCRUDCE branch October 22, 2024 12:14

This was referenced Oct 23, 2024

test: fix tabs skipped test CE #37023

Merged

test: fix datepicker tests #37042

Merged

coderabbitai bot mentioned this pull request Nov 13, 2024

test: Skipping test becasuea of an open Issue[RestAPIDatasrouce spec] #37354

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: udpated locator for GenetateCrud test #37000

test: udpated locator for GenetateCrud test #37000

NandanAnantharamu commented Oct 21, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Oct 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

NandanAnantharamu commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

NandanAnantharamu commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

test: udpated locator for GenetateCrud test #37000

test: udpated locator for GenetateCrud test #37000

Conversation

NandanAnantharamu commented Oct 21, 2024 • edited by github-actions bot Loading

coderabbitai bot commented Oct 21, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

NandanAnantharamu commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

NandanAnantharamu commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

NandanAnantharamu commented Oct 21, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Oct 21, 2024 •

edited

Loading