-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed old flags for airgap instances #36609
Changes from all commits
9c009d8
972c1b9
c410ba8
1786523
b92a9d0
63010c6
92ce628
7ffad1b
b956497
a02168b
c2158d8
2bdc8f5
1089048
90a54af
19b10cf
9461218
b30c9bb
126121f
bfbf6bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -74,8 +74,10 @@ describe( | |||||
|
||||||
it("2. Validate table navigation with Server Side pagination enabled with Default selected row", () => { | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("pagination"); | ||||||
agHelper.AssertExistingToggleState("Server side pagination", "true"); | ||||||
|
||||||
propPane.ExpandIfCollapsedSection("rowselection"); | ||||||
propPane | ||||||
.ValidatePropertyFieldValue("Default selected row", "0") | ||||||
.then(($selectedRow: any) => { | ||||||
|
@@ -114,6 +116,7 @@ describe( | |||||
deployMode.NavigateBacktoEditor(); | ||||||
table.WaitUntilTableLoad(0, 0, "v2"); | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("pagination"); | ||||||
propPane.TogglePropertyState("Server side pagination", "Off"); | ||||||
deployMode.DeployApp(); | ||||||
table.WaitUntilTableLoad(0, 0, "v2"); | ||||||
|
@@ -122,10 +125,12 @@ describe( | |||||
deployMode.NavigateBacktoEditor(); | ||||||
table.WaitUntilTableLoad(0, 0, "v2"); | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("pagination"); | ||||||
propPane.TogglePropertyState("Server side pagination", "On"); | ||||||
}); | ||||||
|
||||||
it("4. Change Default selected row in table and verify", () => { | ||||||
propPane.ExpandIfCollapsedSection("rowselection"); | ||||||
propPane.UpdatePropertyFieldValue("Default selected row", "1"); | ||||||
deployMode.DeployApp(); | ||||||
table.WaitUntilTableLoad(0, 0, "v2"); | ||||||
|
@@ -140,6 +145,7 @@ describe( | |||||
|
||||||
it("5. Verify Default search text in table as per 'Default search text' property set + Bug 12228", () => { | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.TypeTextIntoField("Default search text", "Bug"); | ||||||
deployMode.DeployApp(); | ||||||
table.AssertSearchText("Bug"); | ||||||
|
@@ -148,6 +154,7 @@ describe( | |||||
deployMode.NavigateBacktoEditor(); | ||||||
|
||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.TypeTextIntoField("Default search text", "Quest", true, false); | ||||||
|
||||||
deployMode.DeployApp(); | ||||||
|
@@ -157,20 +164,23 @@ describe( | |||||
table.WaitUntilTableLoad(0, 0, "v2"); | ||||||
|
||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.TypeTextIntoField("Default search text", "Epic"); //Bug 12228 - Searching based on hidden column value should not be allowed | ||||||
deployMode.DeployApp(); | ||||||
table.AssertSearchText("Epic"); | ||||||
table.WaitForTableEmpty("v2"); | ||||||
deployMode.NavigateBacktoEditor(); | ||||||
|
||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.RemoveText("defaultsearchtext"); | ||||||
agHelper.GetNClick(dataSources._refreshIcon, 0, true); | ||||||
table.WaitUntilTableLoad(0, 0, "v2"); | ||||||
}); | ||||||
|
||||||
it("6. Validate Search table with Client Side Search enabled & disabled & onSearchTextChanged is set", () => { | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirm the necessity of the escape character in 'search\&filters' Double-check whether the backslash in "search\&filters" is necessary. Using unnecessary escape characters can cause confusion and potential errors. Suggested change: -propPane.ExpandIfCollapsedSection("search\\&filters");
+propPane.ExpandIfCollapsedSection("search&filters"); 📝 Committable suggestion
Suggested change
|
||||||
agHelper.AssertExistingToggleState("Client side search", "true"); | ||||||
|
||||||
deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE)); | ||||||
|
@@ -188,6 +198,7 @@ describe( | |||||
table.WaitUntilTableLoad(0, 1, "v2"); | ||||||
|
||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.TogglePropertyState("Client side search", "Off"); | ||||||
|
||||||
deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE)); | ||||||
|
@@ -205,6 +216,7 @@ describe( | |||||
deployMode.NavigateBacktoEditor(); | ||||||
table.WaitUntilTableLoad(0, 1, "v2"); | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.TogglePropertyState("Client side search", "On"); | ||||||
propPane.EnterJSContext("onSearchTextChanged", ""); | ||||||
propPane.ToggleJSMode("onSearchTextChanged", false); | ||||||
|
@@ -224,6 +236,7 @@ describe( | |||||
deployMode.NavigateBacktoEditor(); | ||||||
table.WaitUntilTableLoad(0, 1, "v2"); | ||||||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||||||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||
propPane.TogglePropertyState("Client side search", "Off"); | ||||||
|
||||||
deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.TABLE)); | ||||||
|
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -20,6 +20,7 @@ describe( | |||||||||||||
cy.readTableV2dataPublish("0", "0").then((tabData) => { | ||||||||||||||
expect(tabData).to.eq("#2"); | ||||||||||||||
}); | ||||||||||||||
_.propPane.ExpandIfCollapsedSection("search\\&filters"); | ||||||||||||||
// Input onsearchtextchanged control | ||||||||||||||
cy.get(".t--property-control-onsearchtextchanged .t--js-toggle") | ||||||||||||||
.first() | ||||||||||||||
Comment on lines
24
to
26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remember to use locator variables and data- attributes instead of CSS selectors* As we've learned, using locator variables and data-* attributes enhances the maintainability and reliability of our tests. Relying on plain strings and CSS paths can make the tests brittle and harder to maintain. Let's replace the CSS selectors with appropriate locator variables. Here's how you might adjust the code: -cy.get(".t--property-control-onsearchtextchanged .t--js-toggle")
- .first()
- .click();
+cy.get(commonlocators.onSearchTextChangedToggle)
+ .click(); If 📝 Committable suggestion
Suggested change
|
||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ describe( | |
); | ||
// validation of data displayed in input widgets based on search value set | ||
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); | ||
Comment on lines
27
to
29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Time for some homework revisions, students! Let's improve our test by avoiding the use of cy.get(".t--property-control-allowsearching input").should('be.visible').click({ force: true }); This way, we're letting Cypress automatically wait for the element to be visible before clicking, which is more reliable than using a fixed wait time. Also applies to: 33-34 |
||
_.propPane.ExpandIfCollapsedSection("search\\&filters"); | ||
cy.get(".t--property-control-allowsearching input").click({ | ||
force: true, | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ describe( | |
it("1. Verify Table Filter for 'empty'", function () { | ||
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250); | ||
// turn on filtering for the table - it is disabled by default in this PR(#34593) | ||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||
agHelper.GetNClick(".t--property-control-allowfiltering input"); | ||
table.AddSampleTableData(); | ||
propPane.UpdatePropertyFieldValue( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using In line 22, the code uses: agHelper.Sleep(2000); //table to filter & records to disappear Relying on fixed delays can lead to flaky tests because the actual load time may vary. Instead, we should wait for a specific element or condition that indicates the table has finished filtering. Consider replacing the sleep with a wait for the table to become empty: table.WaitForTableEmpty("v2"); This ensures the test proceeds only after the table is fully filtered. |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ describe( | |
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250); | ||
//propPane.EnterJSContext("Table data", JSON.stringify(this.dataSet.TableInput)); | ||
// turn on filtering for the table - it is disabled by default in this PR(#34593) | ||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||
agHelper.GetNClick(".t--property-control-allowfiltering input"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Let's improve selector usage by adopting locator variables In line 21, you're directly using a CSS selector To implement this improvement, let's define a locator variable using a Add the following in your locators file (e.g., export const allowFilteringToggle = '[data-cy="t--property-control-allowfiltering"] input'; Then, update line 21 as shown below: - agHelper.GetNClick(".t--property-control-allowfiltering input");
+ agHelper.GetNClick(allowFilteringToggle); |
||
table.AddSampleTableData(); | ||
//propPane.EnterJSContext("Table Data", JSON.stringify(this.dataSet.TableInput)); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ describe( | |
before(() => { | ||
entityExplorer.DragDropWidgetNVerify("tablewidgetv2", 650, 250); | ||
// turn on filtering for the table - it is disabled by default in this PR(#34593) | ||
propPane.ExpandIfCollapsedSection("search\\&filters"); | ||
agHelper.GetNClick(".t--property-control-allowfiltering input"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remember to use locator variables instead of plain strings for selectors. In line 32, you've used a plain string selector in Let's define a locator variable for |
||
propPane.EnterJSContext("Table data", JSON.stringify(data)); | ||
assertHelper.AssertNetworkStatus("@updateLayout"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the escape characters in 'search\&filters'
It appears you're using an extra backslash in "search\&filters". Ensure this is intentional, as unnecessary escape characters might lead to issues. If the section name is "search&filters", you can write it without the double backslash.
Proposed change:
📝 Committable suggestion