Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Run unit test with separate data. DO NOT MERGE #36592

Closed
wants to merge 22 commits into from
Closed

chore: Run unit test with separate data. DO NOT MERGE #36592

wants to merge 22 commits into from

Commits on Sep 19, 2024

  1. adjust moment inputFormat for Unix ms + allow validate unix ms in tra… 

    …nsformDatePureFn
    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5ab2834 View commit details
    Browse the repository at this point in the history

  2. add enum for MomentDateInputFormat

    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1a4ebe9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o fix/incorrect-selected-date-in-table-date-cell
    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c97031f View commit details
    Browse the repository at this point in the history

  4. add base test

    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6b6b7a8 View commit details
    Browse the repository at this point in the history

  5. improve test

    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    94ef32d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. improve Date_column_editing_2_spec

    @jacquesikot
    jacquesikot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    da89194 View commit details
    Browse the repository at this point in the history

  2. complete test

    @jacquesikot
    jacquesikot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2621b9a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. extract helper and fixtures in test case

    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    877f4ce View commit details
    Browse the repository at this point in the history

  2. improve transformDataPureFn - remove redundant !isNumber(value) check… 

    … for EPOCK and MILLISECONDS format
    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    68facfb View commit details
    Browse the repository at this point in the history

  3. improve transformDataPureFn - remove redundant !isNumber(value) check… 

    … for EPOCK and MILLISECONDS format
    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    33da955 View commit details
    Browse the repository at this point in the history

  4. add base test for transformDataPureFn

    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d6ec6ae View commit details
    Browse the repository at this point in the history

  5. complete transformDataPureFn unit test

    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2ec53d1 View commit details
    Browse the repository at this point in the history

  6. extract test fixtures

    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4b5f373 View commit details
    Browse the repository at this point in the history

  7. remove TODO comment

    @jacquesikot
    jacquesikot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    aca19a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. add formattedDate to isNewRow

    @jacquesikot
    jacquesikot committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    36c32d6 View commit details
    Browse the repository at this point in the history

  2. fix: extract momentAdjustedInputFormat into a function in DateCell

    @jacquesikot
    jacquesikot committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d8701f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. extend test to cover all table column date types

    @jacquesikot
    jacquesikot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    17fa7e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. fix test case and move fixtures

    @jacquesikot
    jacquesikot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2abc737 View commit details
    Browse the repository at this point in the history

  2. remove .only from test

    @jacquesikot
    jacquesikot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    17e8f41 View commit details
    Browse the repository at this point in the history

  3. check unit test

    @jacquesikot
    jacquesikot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dfe7b65 View commit details
    Browse the repository at this point in the history

  4. add helper in Table.ts

    @jacquesikot
    jacquesikot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b13f966 View commit details
    Browse the repository at this point in the history

  5. Run unit test with separate data.

    @rahulbarwal
    rahulbarwal committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    325f896 View commit details
    Browse the repository at this point in the history