Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix this.rootSpan undefined bug in PageLoadInstrumentation #36459

Merged
merged 3 commits into from
Sep 23, 2024
Merged

chore: fix this.rootSpan undefined bug in PageLoadInstrumentation #36459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bd957e
chore: fix a method binding bug in PageLoadInstrumentation
dvj1988 Sep 20, 2024
e1b888a
Convert enable to an arrow fn
dvj1988 Sep 20, 2024
d40ebc1
move all methods to init
dvj1988 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/client/src/UITelemetry/PageLoadInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,12 @@ export class PageLoadInstrumentation extends InstrumentationBase {
this.ignoreResourceUrls = ignoreResourceUrls;
// Start the root span for the page load
this.rootSpan = startRootSpan("PAGE_LOAD", {}, 0);
}

init() {
// init method is present in the base class and needs to be implemented
// This is method is never called by the OpenTelemetry SDK
// Leaving it empty as it is done by other OpenTelemetry instrumentation classes
// Initialize the instrumentation after starting the root span
this.init();
}

enable(): void {
init() {
// Register connection change listener
this.addConnectionAttributes();

Expand All @@ -71,6 +68,11 @@ export class PageLoadInstrumentation extends InstrumentationBase {
}
}

enable() {
// enable method is present in the base class and needs to be implemented
// Leaving it empty as there is no need to do anything here
}

private addDeviceAttributes() {
this.rootSpan.setAttributes({
deviceMemory: (navigator as TNavigator).deviceMemory,
Expand Down
Loading