Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In the search results we can see the list of applicaions but not the workspaces which it belongs too #36367

Open
wants to merge 5 commits into
base: release
Choose a base branch
from

Conversation

a6hishekpandey
Copy link
Contributor

@a6hishekpandey a6hishekpandey commented Sep 17, 2024

Description

Issue: In the search results we can see the list of applicaions but not the workspaces which it belongs too.

This PR addresses issue #36355, I am filtering applications in search using selected workspace id to display applications which belongs to current workspace only.

Fixes #36355

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Introduced a selectedWorkspaceId prop across multiple search components, enhancing filtering of applications based on the selected workspace.
    • Improved search functionality in both desktop and mobile interfaces by integrating workspace context.
  • Bug Fixes

    • Resolved issues with displaying applications by ensuring only relevant applications for the selected workspace are shown.

Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

The changes made in this pull request introduce a new prop, selectedWorkspaceId, across several components related to the search functionality. This prop allows the application to filter search results based on the currently selected workspace, ensuring that only relevant applications are displayed. The updates affect the ApplicationSearchItem, DesktopEntitySearchField, EntitySearchBar, and MobileEntitySearchField, enhancing the search experience by incorporating workspace context.

Changes

File Change Summary
app/client/src/pages/common/SearchBar/ApplicationSearchItem.tsx Added selectedWorkspaceId prop to filter applications based on the selected workspace.
app/client/src/pages/common/SearchBar/DesktopEntitySearchField.tsx Introduced selectedWorkspaceId prop, passed to ApplicationSearchItem for workspace-specific logic.
app/client/src/pages/common/SearchBar/EntitySearchBar.tsx Added dependency on getCurrentWorkspaceId to manage state and pass selectedWorkspaceId to search fields.
app/client/src/pages/common/SearchBar/MobileEntitySearchField.tsx Added selectedWorkspaceId prop, enhancing mobile search functionality with workspace context.

Assessment against linked issues

Objective Addressed Explanation
Display applications with their respective workspaces (#36355)

Poem

In workspaces bright, where apps do play,
A search now finds its rightful way.
With selectedWorkspaceId in tow,
Relevant results begin to flow.
So let us cheer this change so grand,
For tailored searches, hand in hand! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

a6hishekpandey and others added 3 commits September 18, 2024 13:11
…ts-we-can-see-the-list-of-applicaions-but-not-the-workspaces-which-it-belongs-too
…e-the-list-of-applicaions-but-not-the-workspaces-which-it-belongs-too
@a6hishekpandey a6hishekpandey changed the title fix: In the search results we can see the list of applicaions but not the workspaces which it belongs too #36355 fix: In the search results we can see the list of applicaions but not the workspaces which it belongs too Sep 19, 2024
</Text>
</SearchListItem>
))}
{applicationsList.map((application: ApplicationPayload) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any possibility for adding unit test here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar-qa007 I am still waiting for the review if we want the fix like this or not? I am little new to open source but with some help I can work on unit tests as well if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: In the search results we can see the list of applicaions but not the workspaces which it belongs too.
2 participants