Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support Validation Section and Required Toggle for Select Column Type #30091

Closed
1 task done
ame-appsmith opened this issue Jan 8, 2024 · 4 comments · Fixed by #36375
Closed
1 task done
Assignees
Labels
Enhancement New feature or request QA Pod Issues under the QA Pod QA Needs QA attention Table Inline Edit Issues related to inline editing Table Widget Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@ame-appsmith
Copy link

ame-appsmith commented Jan 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Summary

The validation section and required toggle are not available for Select column types.
We only provide the Required toggle and the Validation section for Plain Text column types, but not for Select column types.

Why should this be worked on?

A user who uses the editable table with a Select column type may want to make this field required.

Front thread

Front logo Front conversations

@ame-appsmith ame-appsmith added Enhancement New feature or request Table Widget labels Jan 8, 2024
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Jan 8, 2024
@github-actions github-actions bot added the Anvil Pod Issue related to Anvil project label Jan 8, 2024
@KelvinOm KelvinOm removed Anvil Pod Issue related to Anvil project Table Widget WDS team labels Mar 27, 2024
@github-actions github-actions bot added the Anvil Pod Issue related to Anvil project label Mar 27, 2024
@github-actions github-actions bot removed the Widgets Product This label groups issues related to widgets label Mar 27, 2024
@KelvinOm KelvinOm removed the Anvil Pod Issue related to Anvil project label Mar 27, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Bug Something isn't working and removed Bug Something isn't working labels Apr 18, 2024
@simonfvr
Copy link

Hello, what's the status of this issue? I can see in the documentation information about the required option, but I'm not able to set a select column required in Appsmith.

@Nikhil-Nandagopal Nikhil-Nandagopal added the Table Inline Edit Issues related to inline editing label Jun 14, 2024
@Nikhil-Nandagopal
Copy link
Contributor

@simonfvr we don't currently have it for the table widget though it exists for the select widget separately

@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Jun 14, 2024
@simonfvr
Copy link

@Nikhil-Nandagopal thanks for your answer, is it planned to implement it for the table widget?

@Nikhil-Nandagopal
Copy link
Contributor

Nikhil-Nandagopal commented Jun 18, 2024

@simonfvr we do, we're just currently backed up with a lot of issue requests. We'll update this Github issue once it's picked up

@appsmith-bot appsmith-bot added the QA Needs QA attention label Sep 23, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Sep 23, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
…org#36375)

## Description

**Problem**
The select column of the table widget does not have a validation
property within its property pane to allow users add an isRequired
validation to the table select column.

**Solution**
Added a Validation section to the table select column's property pane,
which includes an isRequired toggle. When enabled, this feature will
trigger a visual indication (error border colour) around the select
widget if a required field is left unselected during "Add new row" or
inline editing.


Fixes appsmithorg#30091 

## Automation

/ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity,
@tag.Select"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10957896180>
> Commit: d2597e6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10957896180&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity,
@tag.Select`
> Spec:
> <hr>Fri, 20 Sep 2024 12:23:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced end-to-end tests for Select column validation in Table
widgets.
- Enhanced validation logic to support Select column types in the Table
widget.
- Added visual feedback for required Select fields during row addition
and inline editing.
- Improved locator for single-select widget button control to enhance UI
interaction.

- **Bug Fixes**
- Improved error handling and visual representation for invalid editable
Select cells.

- **Documentation**
- Updated validation configuration to include Select column types for
better usability.

- **Refactor**
	- Enhanced code clarity for styled components related to Select fields.
- Modified method to improve versatility in handling table interactions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Sai Charan <[email protected]>
Co-authored-by: Pawan Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request QA Pod Issues under the QA Pod QA Needs QA attention Table Inline Edit Issues related to inline editing Table Widget Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging a pull request may close this issue.