fix: race condition on first mount #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, systemd tries to mount /nix/store as soon as they see that /dev/sda partition table changes. I observed sometimes that if systemd tries to mount /dev/sda2 while systemd-repart is modifying the device, then a boot failure happens:
This is not the case always; but when it happens, the user is prompted to go to the recovery console.
This small change prevents /sysroot/nix/store from getting mounted before systemd-repart is done. I'm not very well versed in systemd/initrd, but looks like the chain of requirements that causes this issue starts with "initrd-fs.target" asking for "rw-etc.service" which asks for "sysroot-nix-store.mount"; and "sysroot.mount" is definitely a requirement for "systemd-repart" according to https://github.com/NixOS/nixpkgs/blob/nixos-25.05/nixos/modules/system/boot/systemd/repart.nix#L185