[IO_URING] Add support for pollAdd operation
#273
Conversation
FranzBusch
requested review from
glessard,
lorentey and
milseman
as code owners
|
@swift-ci please test |
FranzBusch
force-pushed
the
fb-io-uring-poll-add
branch
2 times, most recently
from
c64fc9c to
e69d5c1
Compare
|
@swift-ci please test |
Catfish-Man
left a comment
Catfish-Man
left a comment
There was a problem hiding this comment.
I had a few comments but I don't think any of them are necessarily blockers
| /// | ||
| /// - ``PollEvents``: The events that can be monitored. | ||
| /// - ``IORing/Request/cancel(_:matching:)``: Cancelling poll operations. | ||
| @inlinable public static func pollAdd( |
There was a problem hiding this comment.
Typically Swift naming style would be verb-first but if there's a good reason to have it this way it's probably fine
There was a problem hiding this comment.
I was trying to match what the io_uring operation was called. I wasn't sure how much we tried to change the naming to fit our Swift naming guidelines.
There was a problem hiding this comment.
I guessed that was probably what you were doing. I remember this coming up during the initial proposal review and iirc folks leaned "don't try to make the names friendlier" so that looking up docs will work better. I'm still torn on it but I see the logic.
There was a problem hiding this comment.
Let me know what you prefer and I am happy to change if needed. I am open to both.
## Motivation To observe events on file descriptors IO_URING supports the `pollAdd` operation. This is useful when you want to observe a file descriptor becoming ready to read or write ## Modifications This PR adds a new `IORing.Request.PollEvents` option set to model the poll masks. Furthermore, it adds a new `static func pollAdd` to the `IORing.Request`. ## Result We can now use IO_URING to poll for events on file descriptors.
FranzBusch
force-pushed
the
fb-io-uring-poll-add
branch
from
e69d5c1 to
5353528
Compare
|
@swift-ci please test |
Motivation
To observe events on file descriptors IO_URING supports the
pollAddoperation. This is useful when you want to observe a file descriptor becoming ready to read or writeModifications
This PR adds a new
IORing.Request.PollEventsoption set to model the poll masks. Furthermore, it adds a newstatic func pollAddto theIORing.Request.Result
We can now use IO_URING to poll for events on file descriptors.