Skip to content

Update Android followSymlinkInits to handle sizeAllocated #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcprux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Android followSymlinkInits to handle sizeAllocated #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Tests/SystemTests/StatTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,12 @@ private struct StatTests {
#expect(targetStat.type == .regular)
#expect(symlinkStat.type == .symbolicLink)
#expect(symlinkStat.size < targetStat.size)

#if os(Android)
#expect(symlinkStat.sizeAllocated <= targetStat.sizeAllocated)
Copy link
Contributor

@rauhul rauhul Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect a citation for this and potentially a documentation update

#else
#expect(symlinkStat.sizeAllocated < targetStat.sizeAllocated)
#endif

// Set each .st_atim back to its original value for comparison

Expand Down