-
Notifications
You must be signed in to change notification settings - Fork 472
Drop Swift 5.9 #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Swift 5.9 #1775
Conversation
Motivation: Swift 5.9 is no longer supported, we should bump the tools version Modifications: * Bump the Swift tools version to Swift 5.10 * Remove unsupported versions from CI in build.yml Result: Code reflects the expected support window.
Looks like you'll need to do |
ps - if you want, split out the changes to generation and one of us can look at doing that if you wanted to avoid having to build protoc also. |
@FranzBusch which semver tag should removing old Swift versions get? |
Should be a SemVer minor |
LGTM, but I'd like one of the core Apple maintainers to sign off since this is officially raising the minimum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the README.md also will need an update to go with this. I think we tried to capture all the final steps in https://github.com/apple/swift-protobuf/blob/main/Documentation/INTERNALS.md#swift-language-support
Motivation:
Swift 5.9 is no longer supported, we should bump the tools version
Modifications:
Result:
Code reflects the expected support window.