Skip to content

Drop Swift 5.9 #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025
Merged

Drop Swift 5.9 #1775

merged 9 commits into from
May 14, 2025

Conversation

rnro
Copy link
Contributor

@rnro rnro commented May 12, 2025

Motivation:

Swift 5.9 is no longer supported, we should bump the tools version

Modifications:

  • Bump the Swift tools version to Swift 5.10
  • Remove unsupported versions from CI in build.yml

Result:

Code reflects the expected support window.

Motivation:

Swift 5.9 is no longer supported, we should bump the tools version

Modifications:

* Bump the Swift tools version to Swift 5.10
* Remove unsupported versions from CI in build.yml

Result:

Code reflects the expected support window.
@thomasvl
Copy link
Collaborator

Looks like you'll need to do make reference regenerate to update the checked in files also.

@thomasvl
Copy link
Collaborator

ps - if you want, split out the changes to generation and one of us can look at doing that if you wanted to avoid having to build protoc also.

@thomasvl
Copy link
Collaborator

@FranzBusch which semver tag should removing old Swift versions get?

@FranzBusch
Copy link
Member

@FranzBusch which semver tag should removing old Swift versions get?

Should be a SemVer minor

@thomasvl thomasvl added the 🆕 semver/minor Adds new public API. label May 12, 2025
@rnro rnro requested a review from thomasvl May 14, 2025 09:22
@thomasvl
Copy link
Collaborator

LGTM, but I'd like one of the core Apple maintainers to sign off since this is officially raising the minimum.

Copy link
Collaborator

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the README.md also will need an update to go with this. I think we tried to capture all the final steps in https://github.com/apple/swift-protobuf/blob/main/Documentation/INTERNALS.md#swift-language-support

@rnro rnro merged commit e41d3f0 into apple:main May 14, 2025
12 checks passed
@rnro rnro deleted the drop_swift_5_9 branch May 14, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants