Partial OpenBSD support. #3394
Open
Partial OpenBSD support. #3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this and tackling the issue yourself. |
rnro
reviewed
Oct 2, 2025
|
I haven't performed a full review yet but I think having some very brief documentation of the current status of BSD support would probably be useful. |
rnro
reviewed
Oct 2, 2025
rnro
reviewed
Oct 2, 2025
rnro
reviewed
Oct 2, 2025
rnro
reviewed
Oct 2, 2025
Additional partial platform support. * Create a new CNIOBSD module for OpenBSD, for general cleanliness, and make use of it throughout. Some of the changes are borrowed directly from CNIOLinux; some may technically be unnecessary; I am erring somewhat on expediency to functionality. * Since `malloc_size` is unavailable on OpenBSD, and some of the helpers make use of ManagedBufferPointer which makes use of it, mark some of this as unavailable as well. * Usual pthread optional typing changes, since pthread types are pointers on this platform. * Add conditionals to exclude other functionality not available here, like IP_RECVPKTINFO or IP_PKTINFO. * d_ino is a backwards-compatibility macro valued token for dirent, so instead, just expand with a conditional. * Use kqueue on OpenBSD. This necessitates adding some conditionals for type and feature compatibility. * The vsock API is unavailable on OpenBSD. Tested the NIOTCPEchoClient and NIOTCPEchoServer appears to work and that swift-nio-ssh (hopefully wlog) builds with a local repository with these changes. Because NIOFS/_NIOFileSystem depend on some non-portable components, such as extended attributes, sendfile, non-portable linkat flags, and renameat2, this is only just partial OpenBSD support, which means that `swift build` on the full swift-nio project won't build cleanly, but at least the portable parts can be used to build servers and clients. This commit will mark the linked bug as fixed; I will open a new bug for file system support. Fixes apple#3383.
…pple#3387) See apple#3386 CC @FranzBusch @ktoso @Lukasa Signed-off-by: Melissa Kilby <[email protected]>
…pple#3389) See apple#3386 CC @FranzBusch @ktoso @Lukasa Signed-off-by: Melissa Kilby <[email protected]> Co-authored-by: Rick Newton-Rogers <[email protected]>
apple#3390) See apple#3386 CC @FranzBusch @ktoso @Lukasa Signed-off-by: Melissa Kilby <[email protected]>
Co-authored-by: Rick Newton-Rogers <[email protected]>
I added a line in README.md in the section describing platform support. |
|
Anything else necessary here? |
|
Hmm, sorry @3405691582 this seems to have gotten stuck. If you can fix up the conflicts we can try to shepherd this through. |
I reviewed the conflicting files from the incoming merge and resolved them. |
Lukasa
reviewed
Oct 22, 2025
Lukasa
reviewed
Oct 22, 2025
3405691582
force-pushed
the
openbsd
branch
3 times, most recently
from
db5c279 to
919d3d9
Compare
Lukasa
reviewed
Oct 23, 2025
Lukasa
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Additional partial platform support.
Modifications:
Create a new CNIOBSD module for OpenBSD, for general cleanliness, and make use of it throughout. Some of the changes are borrowed directly from CNIOLinux; some may technically be unnecessary; I am erring somewhat on expediency to functionality.
Since
malloc_sizeis unavailable on OpenBSD, and some of the helpers make use of ManagedBufferPointer which makes use of it, mark some of this as unavailable as well.Usual pthread optional typing changes, since pthread types are pointers on this platform.
Add conditionals to exclude other functionality not available here, like IP_RECVPKTINFO or IP_PKTINFO.
d_ino is a backwards-compatibility macro valued token for dirent, so instead, just expand with a conditional.
Use kqueue on OpenBSD. This necessitates adding some conditionals for type and feature compatibility.
The vsock API is unavailable on OpenBSD.
Result:
Tested the NIOTCPEchoClient and NIOTCPEchoServer appears to work and that swift-nio-ssh (hopefully wlog) builds with a local repository with these changes.
Because NIOFS/_NIOFileSystem depend on some non-portable components, such as extended attributes, sendfile, non-portable linkat flags, and renameat2, this is only just partial OpenBSD support, which means that
swift buildon the full swift-nio project won't build cleanly, but at least the portable parts can be used to build servers and clients. This commit will mark the linked bug as fixed; I will open a new bug for file system support.Fixes #3383.