Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Update TensorFlow-specific Swift formatters. #1559

Open
wants to merge 1 commit into
base: tensorflow
Choose a base branch
from

Conversation

dan-zheng
Copy link
Collaborator

Remove TensorXD and ArrayXD formatters.
Those types have been deleted.

Remove `TensorXD` and `ArrayXD` formatters.
Those types have been deleted.
@dan-zheng dan-zheng requested a review from marcrasi May 10, 2019 16:34
@dan-zheng
Copy link
Collaborator Author

Manually tested with a full Swift toolchain on macOS.

$ swift
Welcome to Swift version 5.0-dev (LLVM 082dec2e22, Swift 6bf3d4b528).
Type :help for assistance.
  1> import TensorFlow
  2> Tensor(1)
$R0: TensorFlow.Tensor<Double> = 1.0

Todo: add a test to test/testcases/lang/swift.

Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, you can also add a test in lit/SwiftREPL [if it's easier for you]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants