This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
"LSP Snippets" option for completion API #1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, I'm probably not going to get around to fully releasing this for the next few weeks, so I will just leave this PR open here until I have time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an "LSP Snippets" option to the completion API, documented in SBCompletionOptions.i.
Basically, these allow us to insert placeholders for arguments when the user selects a function from the autocomplete menu. Monaco-based editors automatically highlight the placeholders and let the user tab between them, so that it's easy for them to fill in all the arguments. It looks like this:
