Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing RSA test 'testHandlingNonStandardKeys' #187

Closed
wants to merge 1 commit into from

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Jun 29, 2023

Fix failing test testHandlingNonStandardKeys

Possible regression from #151 ? The tests failed for me when I set let development = true in Package.swift and run target "My Mac" running 13.5 Beta (22G5059d) on a Macbook M1.

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

Tests should not fail.

Modifications:

Changed from XCTAssertEqual which failed to XCTAssertThrowsError to capture the fact that the test tests PEM and DER representations which were not a multiple of 8 bits in length.

Result:

All tests pass.

@Lukasa
Copy link
Collaborator

Lukasa commented Jun 29, 2023

This is not a regression but a behavioural change, see #185. A fix has been discussed there.

@Lukasa Lukasa closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants