Add floating point parsers #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
force-pushed
the
floating-point-parsers
branch
10 times, most recently
from
cbd8d89 to
dc08d17
Compare
natecook1000
force-pushed
the
floating-point-parsers
branch
from
dc08d17 to
1382651
Compare
Member
Author
|
The API documentation is good for now – I'll follow up with DocC curation for these, the LEB parsers, and other APIs we add before the next release. |
| // See https://swift.org/LICENSE.txt for license information | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
Member
There was a problem hiding this comment.
This needs to be #if'd out on macOS/Intel.
#if !((os(macOS) || targetEnvironment(macCatalyst)) && arch(x86_64))
extension Float16 {
// ...
}
#endif
Member
There was a problem hiding this comment.
We may want to provide a Float(parsingFloat16:) as a workaround for macOS/Intel systems, but that can be a follow-on PR.
| //#else | ||
| //public struct Float80: Sendable, Equatable { | ||
| // init(sign: FloatingPointSign, exponentBitPattern: UInt, significandBitPattern: UInt64) {} | ||
| //} |
Member
There was a problem hiding this comment.
As with Float16, if anything what I would provide here is a fallback bailable parser that tries to parse the Float80 into a Double (what to do for out-of-range values TBD).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parsers for the standard library floating point types with endianness specifiers. Resolves #25.
Checklist
Scripts/format.shto correctly format my change