Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unexpected response leaks for multi-address client instances #3096

Merged
merged 3 commits into from
Nov 11, 2024

Commits on Nov 9, 2024

  1. Detect unexpected response leaks for multi-address client instances

    Motivation:
    
    We already apply `HttpMessageDiscardWatchdogClientFilter` to
    single-address clients to detect response leaks that could be caused by
    unhandled exceptions in the filter chain. Multi-address client adds more
    logic around a client group and therefore also could leak responses if
    case on unexpected exceptions.
    
    Modifications:
    
    - Apply `HttpMessageDiscardWatchdogClientFilter` to multi-address client
    instances;
    - Enhance `HttpMessageDiscardWatchdogClientFilter` to include unhandled
    exception in the logs to help narrow down the leak cause;
    
    Result:
    
    Users will see warn message if their multi-address client leaks
    responses.
    idelpivnitskiy committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    b080620 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f191ac0 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    2601251 View commit details
    Browse the repository at this point in the history