Skip to content

Fix NPE in VmTyped.hashCode when property is null #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jurajmaj wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

Fix NPE in VmTyped.hashCode when property is null #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba027a
Fix NPE in VmTyped.hashCode when property is null
jurajmaj Nov 15, 2025
7a0b32c
Use stackOverflowError for circular reference handling in hashCode
jurajmaj Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright © 2024 Apple Inc. and the Pkl project authors. All rights reserved.
* Copyright © 2024-2025 Apple Inc. and the Pkl project authors. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -345,6 +345,10 @@ public VmExceptionBuilder withInsertedStackFrames(
return this;
}

public VmExceptionBuilder stackOverflowError() {
return evalError("stackOverflow");
}

public VmException build() {
if (message == null) {
throw new IllegalStateException("No message set.");
Expand Down
2 changes: 1 addition & 1 deletion pkl-core/src/main/java/org/pkl/core/runtime/VmTyped.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public int hashCode() {

for (var key : clazz.getAllRegularPropertyNames()) {
var value = getCachedValue(key);
assert value != null;
if (value == null) throw new VmExceptionBuilder().stackOverflowError().build();
result = 31 * result + value.hashCode();
}

Expand Down