Skip to content

Conversation

saehejkang
Copy link

@saehejkang saehejkang commented Oct 8, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Closes #386

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@jglogan
Copy link
Contributor

jglogan commented Oct 9, 2025

Hi @saehejkang!

I think that the preference on the issue was to define none as a reserved "network name" as you have done with your constant definition, and instead of a new --no-network flag, --network none would signify that the attachment list would be empty instead of the default.

Could you revise the PR to use --network none in place of --no-network? I'll also add review comments. Thanks again!

@saehejkang saehejkang force-pushed the container-create-run-no-network-attached branch 3 times, most recently from 96a4272 to 392d5aa Compare October 9, 2025 07:20
@saehejkang saehejkang changed the title [container-run-create]: add --no-network flag [container-run-create]: add support for --network none Oct 9, 2025
@saehejkang saehejkang force-pushed the container-create-run-no-network-attached branch from 392d5aa to ad90b43 Compare October 9, 2025 07:50
@saehejkang saehejkang force-pushed the container-create-run-no-network-attached branch from ad90b43 to ab78d7a Compare October 10, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Add option to create/run a container that has no network attachment.

2 participants