Add --max-concurrent-downloads flag for parallel layer downloads #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk142789
approved these changes
Oct 6, 2025
jglogan
reviewed
Oct 7, 2025
| @@ -0,0 +1,109 @@ | |||
| #!/usr/bin/env swift | |||
There was a problem hiding this comment.
Why is this and test_parameter_flow.swift in the top level directory?
There was a problem hiding this comment.
should they belong in Tests/CLITests/Subcommands/Images/?
dcantah
reviewed
Oct 10, 2025
dcantah
reviewed
Oct 10, 2025
| guard err.isCode(.notFound) else { | ||
| throw err | ||
| } | ||
| return try await Self.pull(reference: reference, platform: platform, scheme: scheme, progressUpdate: progressUpdate) |
There was a problem hiding this comment.
I'm somewhat confused by the commit description however. I thought we had found we do pull layers in parallel, but that it's just a hardcoded 8.
There was a problem hiding this comment.
sorry I originally thought it wasn't pulling in parallel but I noticed it was hardcoded later
There was a problem hiding this comment.
updated original issue to more accurately reflect this: #715
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
c843892 to
cc15745
Compare
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
cc15745 to
26ebe63
Compare
Implements concurrent layer downloads to improve image pull performance by fetching multiple layers simultaneously instead of sequentially.
sbhavani
force-pushed
the
feature/parallel-layer-downloads
branch
from
26ebe63 to
53e6c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--max-concurrent-downloadsflag tocontainer image pullfor configurable concurrent layer downloads.Fixes #715
Depends on apple/containerization#311
Usage:
Changes:
Performance: ~1.2-1.3x faster pulls for multi-layer images with higher concurrency
Tests: Included standalone tests verify concurrency behavior and parameter flow