Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable 4- and 8-device Flash Attention layers tests. #1027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Enable 4- and 8-device Flash Attention layers tests. #1027

wants to merge 1 commit into from
+9 −0

Conversation

liboyue
Copy link

@liboyue liboyue commented Feb 28, 2025 •
edited
Loading

This PR enabled 4- and 8-device Flash Attention layers tests. These tests were actually skipped because there is only one device. Ideally we should use pytest marks to mark multi-device tests.

@liboyue liboyue requested review from ruomingp, markblee and a team as code owners February 28, 2025 01:22
kelvinzou
kelvinzou suggested changes Feb 28, 2025
View reviewed changes
Copy link

@kelvinzou kelvinzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Boyue is filing this PR for google debugging purpose. CPU + simulated multi-device is having bug in pallas path and let's not check in this by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinzou kelvinzou kelvinzou requested changes

@ruomingp ruomingp ruomingp approved these changes

@markblee markblee Awaiting requested review from markblee markblee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liboyue @kelvinzou @ruomingp