Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swap check for Widget and WebElement - Allows Widget extensions to im… #2277

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Swap check for Widget and WebElement - Allows Widget extensions to im… #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/io/appium/java_client/pagefactory/AppiumFieldDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ protected boolean isDecoratableList(Field field) {
* @return a field value or null.
*/
public Object decorate(ClassLoader ignored, Field field) {
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be also possible to add a test which verifies this behavior?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do so yes

Object result = defaultElementFieldDecorator.decorate(ignored, field);
return result == null ? decorateWidget(field) : result;
Object result = decorateWidget(field);
return result == null ? defaultElementFieldDecorator.decorate(ignored, field) : result;
}

@Nullable
Expand Down
Loading