feat: add placeholderValue to page source tree #1016
Conversation
Moved the logic for constructing attribute blocks into a separate method for clarity and future extensibility. Also replaced direct type checks with a reusable fb_supportsPlaceholder helper on FBXCElementSnapshotWrapper.
… comment - Replaced custom placeholder support check with FBDoesElementSupportInnerText, as introduced in upstream PR - Updated comment for fb_attributeBlockMapForSnapshot to clarify usage context and avoid confusion about method placement
ikharebashviliGD
force-pushed
the
feat/add_placeholderValue_to_page_source
branch
from
3281454 to
7e9dbb4
Compare
…pedSnapshot method
## [9.7.0](v9.6.3...v9.7.0) (2025-05-20) ### Features * add placeholderValue to page source tree ([#1016](#1016)) ([509c207](509c207))
|
🎉 This PR is included in version 9.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @ikharebashviliGD, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you! |
@jlipps @KazuCocoa Thank you very much! It's a pleasure. |
Summary
This PR adds support for the placeholderValue attribute to be included in the response from the
/source(getPageSource) endpoint.Motivation
Previously,
placeholderValuewas only available when requesting attributes for a specific element. However, this attribute is also valuable when analyzing the full accessibility tree returned by/source, particularly for identifying input fields and verifying placeholder text during automated accessibility testing.By including
placeholderValuein the full snapshot, we enable better support for end-to-end validations and tools that rely on the complete accessibility hierarchy.