Repository navigation
Conversation
Daniel-ADFA
reviewed
Oct 5, 2026
Daniel-ADFA
left a comment
Collaborator
There was a problem hiding this comment.
Review of ADFA-6303 at 8ef6f88 (top of its stack; base is feat/ADFA-6279-agent-capability-tags, no PR stacked above).
IMPORTANT
- IndexCoordinator.kt:133 - a superseding build can run concurrently with a pending clear and end up with a partial index
- SemanticSearchSettingsViewModel.kt:209 - Clear index is disabled in the Build failed state, the one state whose message tells the user to clear
- SemanticSearchSettingsFragment.kt:187 - a pick-only picker removes the free-text escape hatch the OpenAI embedding filter depends on
MINOR
- GeminiSettingsFragment.kt:764 (removed) - retired saved Gemini embedding models are no longer migrated
This repo has no written approve/request-changes rule, so the default severity table applied.
Shows backend support, picks the embedding model and reports index state, progress and build history. SemanticSearchSourceImpl is rebuilt with the IndexCoordinator on each activate. Refs: ADFA-6303
jatezzz
force-pushed
the
feat/ADFA-6303-vector-search-settings-screen
branch
from
October 6, 2026 13:21
8ef6f88 to
dd6596a
Compare
Builds wait for a pending clear, Clear index works after a failed build, the embedding model can be typed, and Gemini moves off a retired saved embedding model. Refs: ADFA-6303
Daniel-ADFA
approved these changes
Oct 6, 2026
Daniel-ADFA
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at f915fd9; no correctness issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until now the embedding model could only be set in each AI provider's own settings, and when a provider couldn't do search, Vector Search showed an error with no fix. Users also couldn't see which provider and model search used, what had been indexed, or that indexing sends their code to the provider. This adds a Vector Search settings screen that shows all of that, lets users pick the embedding model, and lets them clear the index.
Technical implementation:
SemanticSearchSettingsFragment/ViewModel shows whether the selected backend works with search, the embedding-model picker, a privacy line, index status, build history, and Clear index with a confirmation dialog.BackendWatchrefreshes the screen whenever the backend or model changes.EmbeddingModelSelectable(listEmbeddingModels/setEmbeddingModelId), and their settings panes no longer show the embedding model. A value saved there before the upgrade is the one the new screen preselects.IndexCoordinatorruns index builds and clears one at a time, so a clear during a build can't leave a partial or mixed-model index. The SQL was split out intoEmbeddingsSql.min_ide_versionis 26.41 for Vector-Search, AI-Agent-Gemini and AI-Agent-OpenAI.Details
Demo:
https://drive.google.com/file/d/1At3aZZe65Xrfg8Pz3e1AZjp_mCbx89By/view?usp=sharing
Ticket
ADFA-6303
Relates to: ADFA-6277
Observation
Dependency: Stacked on
feat/ADFA-6279-agent-capability-tags(ADFA-6279); needs CoGo 26.41's plugin-api (EmbeddingModelSelectable).