Repository navigation
K2GO-450 fix(install): a hard Ansible crash always fails, even after a clean recap - #632
Merged
Merged
Conversation
…a clean recap Code-review second-pass catch. The prior commit lumped the hard crash signatures (Unable to use multiprocessing / HEARTBEAT SESSION STOPPED) with [ERROR] into one flag that failed() ignored once any PLAY RECAP was seen. IIAB emits several intermediate recaps, so an early clean recap could mask a later crash that exits 0 (the ADFA-4435 case). Split the hard crash signatures into their own flag that always fails; [ERROR] stays recap-suppressible (the ignored-error fix). +regression test (crash after a clean recap).
…/K2GO-450-forgejo-seed-fail-loud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the K2GO-450 fix (PR #631): the code-review's second pass found
this, but the commit landed after #631 was merged, so it is not yet in main.
The merged fix made AnsibleRunOutcome trust the PLAY RECAP and ignore stray
[ERROR] lines, so an ignored ansible error no longer false-fails a module
install. But it lumped the hard crash signatures (Unable to use multiprocessing
/ HEARTBEAT SESSION STOPPED) in with [ERROR]: once any clean PLAY RECAP was
seen, failed() returned the recap verdict and ignored a crash. IIAB emits
several intermediate recaps, so a crash that exits 0 after an early clean recap
(the ADFA-4435 case) could be reported as success.
Change: track the hard crash signatures in their own flag that always fails,
before the recap is consulted; [ERROR] stays recap-suppressible (the
ignored-error fix), and a non-zero exit still always fails.
Verification: AnsibleRunOutcomeTest green, including the added
crashSignatureAfterCleanRecap_isStillFailed (fails on the pre-change code,
passes now). Pure JVM domain change.