Repository navigation
K2GO-439 fix(theme): dark status bar icons in light theme - #624
Merged
Merged
Conversation
Theme.K2Go never set windowLightStatusBar, so the status bar icons stayed light in both themes. targetSdk 35 forces edge-to-edge and drops the system auto-scrim, so in light theme the light icons became unreadable on the light background. Set windowLightStatusBar and windowLightNavigationBar from a day/night qualified bool (values[-night]/bools.xml), the same pattern as the color tokens.
Lint NewApi blocks android:windowLightNavigationBar in values/ (it needs API 27, minSdk is 24). The reported issue is the status bar, and the navigation bar renders correctly, so drop the attr instead of gating it in values-v27. windowLightStatusBar (API 23) stays and still fixes the light-theme icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to K2GO-439 (targetSdk 35 edge-to-edge).
Theme.K2Go never set windowLightStatusBar, so the status bar icons stayed light
in both themes. targetSdk 35 forces edge-to-edge and drops the system auto-scrim,
so in light theme the light icons were unreadable on the light background.
Set windowLightStatusBar and windowLightNavigationBar on Theme.K2Go from a
day/night qualified bool (values[-night]/bools.xml), so the theme is the single
source (no code path sets bar appearance).
Verification: resources link clean (processStandardDebugResources); visual check
on emulator/device.