Repository navigation
K2GO-440 fix(updaters): source the add-ons and build-assets mirrors from the self-updating clone - #623
Merged
Conversation
…rom the self-updating clone Point the refresh wrappers at the mirror in /opt/iiab-android (which dash-node self-updates via git reset), with a fallback to the bake-time copy in the ansible roles dir. A mirror fix then ships via self-update with no rebake, like forgejo-refresh.sh already sources its orchestration from the clone. The two roles are Knowledge to Go overlays, not IIAB upstream. ADR: controller/docs/ADR-updater-self-update-no-rebake.md.
…l Rebuild needs no version bump) The updater code reaches a box through the dash-node rebuild (git reset of the clone), triggered from the Dashboard detail screen. Note both paths: the auto "update available" prompt needs a package.json bump, but the always-present manual Rebuild deploys a mirror/wrapper fix with no bump. Content-refresh actions do not update the updater code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point the add-ons and build-assets refresh wrappers at the mirror in the
self-updating clone (/opt/iiab-android), with a fallback to the bake-time copy in
the ansible roles directory. A mirror fix then ships via dash-node's existing
self-update (git reset), with no rootfs rebake.
Why
The add-ons and build-assets roles are Knowledge to Go overlays, not IIAB
upstream roles: their mirror scripts live in our repo and are carried into the
self-updating clone, but the wrappers read the bake-time copy, which only a full
rebake refreshes. So a two-line mirror fix forces a fleet rebake today. Forgejo
already avoids this by sourcing its orchestration from the clone; this makes the
other two consistent.
Changes
the clone copy when present, else the baked copy.
copy; the no-rebake benefit targets the live refresh, where minor changes are
consumed.
box-vs-APK forward-compat boundary; the general policy is K2GO-447).
Verification
bash -nclean; resolver logic emulated (clone-if-present elsebaked).
/opt/iiab-android/tools/upstream-patches/, and build-iiab-rootfs.sh asserts the
clone exists. The fallback keeps the change safe even if the clone copy is
absent (behaves as today).
or the next rebake.
Notes
self-update git reset carries them.