Repository navigation
K2GO-434 refactor(setup): rebuild view-state + pipeline-loop controller (slices 5, 3b) - #602
Merged
Merged
Conversation
… a pure rule Move the rebuild state -> view decision (phase + bottom-controls mode) out of renderRebuild() into setup/domain/RebuildUiState (semantic enums, pure JVM, unit-tested). renderRebuild() maps the phase to the row, status line and controls, and keeps the st.message override. No behavior change.
… controller Move the readyPoll loop + orchestrateStep + the pipeline latch state out of SetupProgressActivity into SetupProgressController (Activity-scoped, driven through a narrow Host); render() and the *InSession/prootActive predicates read the latches back through getters. Behavior-preserving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract two more SetupProgressActivity concerns into their own units.
phase/controls decision, replacing the inline logic in renderRebuild().
provisioning-loop (readyPoll + orchestrateStep) and its latches; the
Activity now resumes/pauses/kicks it and reads state via getters.
Behavior-preserving. 35 JVM domain tests green. Slice 3b device-smoked
on a OnePlus (OnePlus7T, Android 15): the "Finishing setup" screen
renders and drives a real ZIM download without crashing.