Repository navigation
K2GO-434 refactor(setup): decomposition ADR + first three pure-domain slices - #600
Merged
luisguzman-adfa merged 5 commits intoSep 30, 2026
Merged
Conversation
Move the setup-run completion + success/failure logic out of SetupProgressActivity.render() into setup/domain/RunVerdict (pure JVM, unit-tested). render() now only gathers a RunSnapshot. No behavior change.
…t tests Review nits on the slice-1 extraction: replace the fully-qualified setup.domain references in render() with imports, and cover the noRest-without-proot branch and a slow server restart in a REST run.
…tate machine Move the four *InSession latch fields (maps/module/forgejo-seed/rebuild) out of SetupProgressActivity into setup/domain/RunScope, a small monotonic latch set (pure JVM, unit-tested). The four session methods now delegate; each still computes its signal from the live sources. No behavior change.
Move the status-line (dot tone + message + ellipsis) and the bottom-controls mode out of render() into setup/domain/SetupUiState (semantic enums, pure JVM, unit-tested). render() gathers the inputs and maps the result to resources and to show()/schedule/cancel. No behavior change.
luisguzman-adfa
deleted the
refactor/K2GO-434-setupprogress-decomposition
branch
September 30, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompose SetupProgressActivity (ADR-434). Strangler-fig, behavior-preserving,
one commit per slice.
render() now gathers inputs and maps results; the three rules are pure JVM and
unit-tested. No behavior change, no dash-node change, no version bump.
Verification: :app:testStandardDebugUnitTest green (30 cases across the three domain tests).