Repository navigation
K2GO-430 feat(dependency): require a minimum dash-node version per module (Forgejo 1.3.7) - #598
Merged
Merged
Conversation
…ersion Forgejo needs dash-node 1.3.7 (its repo status/refresh endpoints); an older dashboard breaks it silently. DashNodeGate hard-blocks a module install below its declared minimum (DashNodeRequirement) and routes to the dashboard update; otherwise, when a dashboard update is available, it suggests updating first. Wired once in openModuleIndex, where every install batch starts. Reuses DashboardVersion, UpdateStatusCache and OpReturnNavigator.
…t/K2GO-430-dashnode-dependency
ModuleRetry.fire now checks DashNodeGate.allowInstall, since a retry starts the index directly and bypassed the batch gate. Dismissing the soft suggestion now proceeds with the install instead of swallowing it. Add a DashboardVersion.atLeast unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate module install on the box dash-node version so an old dashboard cannot silently break a module.
a dialog routes to the dashboard update. Wired in openModuleIndex (all batch installs) and ModuleRetry.
(domain registry + gate). l10n to all 33 locales. App-only (no dash-node change).
Verified: unit tests + lint green; device-tested on a box with dash-node 1.3.5 (Forgejo install blocked,
routes to the dashboard update).