Repository navigation
K2GO-426 fix(modules): show the detail hero glyph centered on a neutral panel - #594
Merged
Merged
Conversation
…al panel The module detail hero drew the raw glyph full width with no tint. It was hard to read on the dark theme and it looked cramped. The glyph now sits centered on a neutral rounded panel (k2go_hero_panel, filled k2go_hairline) and is tinted from the theme (k2go_teal), the same look the Dashboard detail already used. The Dashboard uses one drawable (ic_card_dashnode) for both the list row bullet and the detail hero, so the two match. Presentational only: no change to install or selection logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The module detail hero drew the raw module glyph full width with no tint, so it
was hard to read on the dark theme and it looked cramped. The glyph now sits
centered on a neutral rounded panel (new k2go_hero_panel, filled k2go_hairline)
and is tinted from the theme (k2go_teal), the same treatment the Dashboard detail
already used. Both detail screens share the panel.
panel background, padding for an even margin, and a theme tint.
the list row bullet) instead of the placeholder, so the Dashboard list and
detail match.
source for both the bullet and the hero.
Verification
Device-verified on a 32-bit build (Samsung A16), light and dark: each module
detail shows its icon centered on the panel and legible on both themes; the
Dashboard shows the same glyph in the list and the detail. Glyph size tuned on
device.
Follow-up to K2GO-426 (module icons and row alignment).