Repository navigation
K2GO-426 feat(modules): show each module icon and align rows with a f… - #592
Merged
Merged
Conversation
…ixed leading slot Module management rows had a checkbox in the leading slot only when a module was selectable; installed / unknown / failed / selector rows and the Dashboard card had nothing there, so the left edge was ragged and there was no per-module cue. The leading slot is now a fixed-width bullet, checkbox XOR icon: the selection checkbox when the module is selectable, otherwise the module icon (tinted from the theme primary). Every row's title starts at the same x. Applies to both the module rows (cardRow) and the Dashboard (REST API) system card (addSystemDashboardCard). - ModuleCards: map imageRes to each module's real icon (kolibri->courses, calibreweb->book, kiwix->wikipedia, code->code, forgejo->forgejo, maps->maps). - New ic_card_matomo (Material bar_chart, the glyph the box index already uses) and ic_card_dashnode (Material dashboard) for the Dashboard card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Module management rows showed a checkbox in the leading slot only for a selectable
module; installed / unknown / failed / selector rows and the Dashboard card had
nothing there, so the left edge was ragged and there was no per-module cue.
The leading slot is now a fixed-width bullet, checkbox XOR icon: the selection
checkbox when the module is selectable, otherwise the module icon (tinted from the
theme primary). Every row's title starts at the same x. Applied to all three list
builders: the module rows (cardRow), the Dashboard (REST API) system card
(addSystemDashboardCard), and the hidden section (addHiddenSection).
calibreweb -> book, kiwix -> wikipedia, code -> code, forgejo -> forgejo,
maps -> maps).
the matomo card) and ic_card_dashnode (Material dashboard) for the Dashboard card.
Verification
Device-verified on a 32-bit build (Samsung A16), light and dark: installed rows show
their icon, selectable rows show the checkbox, and all titles align (module rows,
Dashboard card, and hidden rows); the hidden Restore button is not crowded. Two-pass
code review clean.