Repository navigation
K2GO-414 fix(proot-builder): disable rsync IDN in the static build (missing libidn2) - #580
Merged
Merged
Conversation
…issing libidn2) The "Build static binaries (PRoot)" workflow started failing in the compile job: rsync's configure aborts with "Failed to find idn2_lookup_ul function in idn2 lib." (runs #26 and #27 on main, commit ac69e21). build_static.sh git-pulls the latest termux-packages each run, and the current rsync enables IDN by default and requires libidn2, which the static build does not provide. Add --disable-idn to rsync's TERMUX_PKG_EXTRA_CONFIGURE_ARGS, next to the other feature disables. IDN (internationalized hostnames) is not used on the K2Go rsync path (local-IP clone/sync); rsync's own configure error recommends this. Upstream drift, not an app change; proot/aria2/tar/gzip/xz all built. Re-running the build must now pass rsync and publish a new binaries-* release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes
Fixes K2GO-414: the "Build static binaries (PRoot)" workflow was failing in the compile job -- rsync's
configureaborts with "Failed to find idn2_lookup_ul function in idn2 lib." (runs #26 and #27 on main).build_static.shgit-pulls the latest termux-packages each run, and the current rsync enables IDN by default and requires libidn2, which the static build does not provide.Adds
--disable-idnto rsync'sTERMUX_PKG_EXTRA_CONFIGURE_ARGS, next to the existing--disable-lz4 --disable-zstd --disable-xxhash --disable-openssl. IDN (internationalized hostnames) is not used on the K2Go rsync path (local-IP clone/sync); rsync's own configure error recommends this. Upstream drift, not an app change -- proot, aria2, tar, gzip, xz all built fine.Verification
bash -npasses. Merging then re-running the "Build static binaries (PRoot)" workflow must now get past rsyncconfigureand reach the smoke + publish jobs, producing a newbinaries-*release (which also carries the K2GO-411 futex fix already on main). Then bumpbinary_version.txt+ninja_manifest.json(the K2GO-59 native-binaries bump).