Repository navigation
ADFA-1982 32-bit production release build - #600
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR adds 32-bit (armeabi-v7a) build support to the release workflow by introducing a GitHub Actions matrix strategy.
Key Changes:
- Added matrix strategy with two variants:
v8(64-bit) andv7(32-bit) - Updated Gradle assemble command to dynamically build the correct variant using
assemble${variant_upper}Release - Modified APK path finding to use
${{ matrix.variant }}instead of hardcodedv8 - Changed build type from hardcoded
"RELEASE"to${{ matrix.build_type }}to distinguish between "RELEASE 64-bit" and "RELEASE 32-bit" in notifications
Impact:
- The workflow will now run twice per execution (once for each variant), doubling the build time and resource usage
- Both 32-bit and 64-bit APKs will be uploaded to Firebase App Distribution with separate Slack notifications
- Testers will receive two separate builds per release
Confidence Score: 4/5
- This PR is safe to merge with low risk - it mirrors existing 64-bit build logic
- The changes are straightforward and follow GitHub Actions best practices. The v7 (32-bit) variant is already defined in the build configuration (AndroidModuleConf.kt:237-242) and used in build tasks (build.gradle.kts:428-441), so the workflow change simply enables building it. Minor risk: increased CI runtime (~2x) and potential for concurrent build failures if resources are limited.
- No files require special attention - the implementation is clean and consistent
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/release.yml | 4/5 | Added matrix strategy to build both 32-bit (v7) and 64-bit (v8) release APKs. Modified build task, APK path finding, and build type references to use matrix variables. |
Sequence Diagram
sequenceDiagram
participant GHA as GitHub Actions
participant Matrix as Matrix Strategy
participant V8 as v8 Build (64-bit)
participant V7 as v7 Build (32-bit)
participant Gradle as Gradle
participant Firebase as Firebase App Distribution
participant Slack as Slack
GHA->>Matrix: Trigger release workflow
Matrix->>V8: Start job with variant=v8
Matrix->>V7: Start job with variant=v7
par 64-bit Build
V8->>V8: Checkout & setup
V8->>V8: Merge stage to main
V8->>Gradle: assembleV8Release
Gradle-->>V8: v8 APK
V8->>Firebase: Upload v8 APK (RELEASE 64-bit)
Firebase-->>V8: Upload success
V8->>Slack: Notify (RELEASE 64-bit)
and 32-bit Build
V7->>V7: Checkout & setup
V7->>V7: Merge stage to main
V7->>Gradle: assembleV7Release
Gradle-->>V7: v7 APK
V7->>Firebase: Upload v7 APK (RELEASE 32-bit)
Firebase-->>V7: Upload success
V7->>Slack: Notify (RELEASE 32-bit)
end
1 file reviewed, no comments
davidschachterADFA
approved these changes
Nov 8, 2025
jatezzz
pushed a commit
that referenced
this pull request
Jun 22, 2026
* add 32-bit release build * address upper error * make build_type a matrix attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 32-bit build to release workflow