Skip to content

ADFA-6174 change dock icon to mean dock not download - #2093

Merged
hal-eisen-adfa merged 3 commits into
stagefrom
ADFA-6174-Change-dock-icon-to-mean-dock-not-download
Oct 2, 2026
Merged

hal-eisen-adfa merged 3 commits into
stagefrom
ADFA-6174-Change-dock-icon-to-mean-dock-not-download

Conversation

@hal-eisen-adfa

@hal-eisen-adfa hal-eisen-adfa commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

No description provided.

Updated drawDock function to include outer window outline and filled strip for docking. This applies the same style Material uses for Dock Left, Dock Right, and Dock Bottom to mean Dock Top, which is essentially what redock does -- it puts the file back at the top of the editor or the very top for performance monitor.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 0fa22f59-22a6-4352-89f7-3ec0aa8922b1

📥 Commits

Reviewing files that changed from the base of the PR and between c78f771 and d9eaaf7.

📒 Files selected for processing (1)
  • floating-window/src/main/java/com/itsaky/androidide/floating/ui/FloatingWindowChrome.kt

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Summary
  • Updated drawDock to show an outlined window with a filled strip along its top edge. The icon now represents docking rather than downloading.
  • The icon uses a style similar to Material’s dock icons.
  • Risk: The PR description notes a Spotless issue. The supplied information does not establish whether it was resolved or whether formatting checks pass.

Walkthrough

drawDock replaces the dock arrow glyph with a window outline and a filled strip along its top edge.

Changes

Dock Icon

Layer / File(s) Summary
Draw the dock window icon
floating-window/src/main/java/com/itsaky/androidide/floating/ui/FloatingWindowChrome.kt
drawDock draws a window outline and a filled top strip instead of the previous dock-arrow lines.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d9eaa

The icon appears to fit its control and implement the intended visual change. No actionable issue is established; it appears ready for normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change to the dock icon and distinguishes it from a download icon.
Description check ✅ Passed The description refers to changing icons and the Spotless problem, which relates to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


A rabbit peeks at the window’s trim,
A bright top strip sits neatly within.
The arrow has hopped out of sight,
The dock wears its new outline bright.
I twitch my nose and thump with delight.

Comment @coderabbitai help to get the list of available commands.

@hal-eisen-adfa
hal-eisen-adfa merged commit e10dd14 into stage Oct 2, 2026
7 checks passed
@hal-eisen-adfa
hal-eisen-adfa deleted the ADFA-6174-Change-dock-icon-to-mean-dock-not-download branch October 2, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants