ADFA-6299: Rename past-tense composable lambda parameters

[hal-eisen-adfa]

ADFA-6299

Fixes lint debt from ADFA-4399 that fails spotlessCheck on any branch that edits FloatingWindowChrome.kt. Unblocks ADFA-6174.

ktlint compose:parameter-naming rejects past-tense lambda parameters in composables. Renames onDragStopped to onDragStop and onResizeStopped to onResizeStop.

Review by commit:

1. Rename - 16 lines in FloatingWindowChrome.kt and FloatingWindow.kt. git grep finds no other uses of the old names.
2. style: spotless reformat, no functional change - the rename puts both files under the Spotless ratchet. Line wraps and indentation only. The reformat cannot go first: spotlessApply stops on the same lint error until the rename is in.

Verified:

• ./gradlew spotlessCheck passes.
• ./gradlew :floating-window:compileV8DebugKotlin passes.

No UI change, so no font-scale check.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 2fb1947d-9a71-46a0-bcd6-70b373323c0a

📥 Commits

Reviewing files that changed from the base of the PR and between deafcc3 and bafe000.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 3397cc49-6f80-4f13-adac-80a15a59f564

📥 Commits

Reviewing files that changed from the base of the PR and between 01a2938 and deafcc3.

📒 Files selected for processing (2)

• floating-window/src/main/java/com/itsaky/androidide/floating/ui/FloatingWindowChrome.kt
• floating-window/src/main/java/com/itsaky/androidide/floating/window/FloatingWindow.kt

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

---

📝 Summary

• Renamed onDragStopped and onResizeStopped to onDragStop and onResizeStop in floating-window callbacks and call sites.
• Updated the minimized bubble monogram to use the first non-whitespace character in the title. It displays • when the title contains no non-whitespace characters.
• Reformatted FloatingWindowChrome.kt and FloatingWindow.kt to satisfy Spotless.
• Risk: Callers that use the renamed parameters as named arguments must update their code.
• The author reports that spotlessCheck and :floating-window:compileV8DebugKotlin pass.

Walkthrough

The floating window chrome renames drag and resize completion callbacks. The minimized bubble now derives its monogram from the first non-whitespace title character, or displays a bullet when the title has no such character. The call site uses the renamed callbacks.

Changes

Floating window chrome

Layer / File(s)	Summary
Chrome callbacks and bubble monogram floating-window/src/main/java/com/itsaky/androidide/floating/ui/FloatingWindowChrome.kt	The chrome, title bar, and resize handle use onDragStop and onResizeStop. The minimized bubble displays the first non-whitespace title character in uppercase, or • for an empty or whitespace-only title. Other listed chrome changes reformat existing logic.
Window call-site wiring floating-window/src/main/java/com/itsaky/androidide/floating/window/FloatingWindow.kt	The FloatingWindowChrome call uses the renamed callback arguments. Other listed changes reformat existing declarations, calculations, and constructor parameters.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to deafc

The callback rename preserves existing window behavior, and blank titles safely display a bullet. No actionable merge-blocking risk was identified; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: renaming past-tense composable lambda parameters.
Description check	✅ Passed	The description directly explains the parameter renames, lint issue, affected files, validation results, and lack of functional change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{A rabbit taps the window frame,
The drag-stop names now match their claim.
A title’s first clear letter shines,
Or • appears between the lines.
The resize handle rests at last,
While formatting changes drift past.}

_{Comment @coderabbitai help to get the list of available commands.}