ADFA-2686: Address CodeRabbit nitpicks on feedback FAB

- feedback_fab.xml: use app:elevation and app:srcCompat (Material-recommended
  attributes) instead of android:elevation / android:src.
- Centralize the FAB margin: add @dimen/feedback_fab_margin (16dp) and reference
  it from all 7 feedback-FAB includes (editor/main/about/preferences/plugin_manager
  plus about land/sw600dp variants) instead of hardcoding 16dp.
- OnboardingActivity: read the same dimen via getDimensionPixelSize instead of a
  hardcoded 16dp TypedValue conversion, so the margin lives in one place.

Author: hal-eisen-adfa

app/src/main/java/com/itsaky/androidide/activities/OnboardingActivity.kt

@@ -19,7 +19,6 @@ package com.itsaky.androidide.activities
 
 import android.content.Intent
 import android.os.Bundle
-import android.util.TypedValue
 import android.view.View
 import android.view.ViewTreeObserver
 import android.view.animation.Animation
@@ -182,11 +181,8 @@ class OnboardingActivity : AppIntro2() {
                         ).apply {
                             startToStart = ConstraintLayout.LayoutParams.PARENT_ID
                             bottomToBottom = ConstraintLayout.LayoutParams.PARENT_ID
-                            val marginInPx = TypedValue.applyDimension(
-                                TypedValue.COMPLEX_UNIT_DIP,
-                                16f,
-                                resources.displayMetrics
-                            ).toInt()
+                            val marginInPx =
+                                resources.getDimensionPixelSize(R.dimen.feedback_fab_margin)
                             setMargins(marginInPx, marginInPx, marginInPx, marginInPx)
                         }
                     }

app/src/main/res/layout-land/activity_about.xml

@@ -123,7 +123,7 @@
       layout="@layout/feedback_fab"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
-      android:layout_margin="16dp"
+      android:layout_margin="@dimen/feedback_fab_margin"
       android:layout_gravity="bottom|start" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>

app/src/main/res/layout-sw600dp/activity_about.xml

@@ -123,7 +123,7 @@
       layout="@layout/feedback_fab"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
-      android:layout_margin="16dp"
+      android:layout_margin="@dimen/feedback_fab_margin"
       android:layout_gravity="bottom|start" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>

app/src/main/res/layout/activity_about.xml

@@ -101,7 +101,7 @@
       layout="@layout/feedback_fab"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
-      android:layout_margin="16dp"
+      android:layout_margin="@dimen/feedback_fab_margin"
       android:layout_gravity="bottom|start" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>

app/src/main/res/layout/activity_editor.xml

@@ -73,7 +73,7 @@
       layout="@layout/feedback_fab"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
-      android:layout_margin="16dp"
+      android:layout_margin="@dimen/feedback_fab_margin"
       app:layout_constraintBottom_toBottomOf="parent"
       app:layout_constraintStart_toStartOf="parent" />
 

app/src/main/res/layout/activity_main.xml

@@ -88,7 +88,7 @@
         layout="@layout/feedback_fab"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_margin="16dp"
+        android:layout_margin="@dimen/feedback_fab_margin"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintStart_toStartOf="parent" />
 

app/src/main/res/layout/activity_plugin_manager.xml

@@ -83,7 +83,7 @@
         layout="@layout/feedback_fab"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_margin="16dp"
+        android:layout_margin="@dimen/feedback_fab_margin"
         android:layout_gravity="bottom|start" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>

app/src/main/res/layout/activity_preferences.xml

@@ -55,6 +55,6 @@
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
       android:layout_gravity="bottom|start"
-      android:layout_margin="16dp" />
+      android:layout_margin="@dimen/feedback_fab_margin" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>

app/src/main/res/layout/feedback_fab.xml

@@ -12,7 +12,7 @@
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
     android:contentDescription="@string/send_feedback"
-    android:elevation="16dp"
-    android:src="@drawable/baseline_feedback_64"
+    app:elevation="16dp"
+    app:srcCompat="@drawable/baseline_feedback_64"
     app:fabCustomSize="@dimen/feedback_fab_size"
     app:maxImageSize="@dimen/feedback_fab_icon_size" />

resources/src/main/res/values/dimens.xml

@@ -14,4 +14,5 @@
          feedback_fab_icon_size controls how snugly the icon fills the circle. -->
     <dimen name="feedback_fab_size">32dp</dimen>
     <dimen name="feedback_fab_icon_size">26dp</dimen>
+    <dimen name="feedback_fab_margin">16dp</dimen>
 </resources>