Repository navigation
Commit 7f3ff75
committed
ADFA-2686: Add feedback FAB to about landscape/sw600dp variants
The land and sw600dp variants of activity_about.xml omitted the feedback
FAB, which violates the invariant that every page must always offer feedback.
Add the shared feedback_fab include to both variants (bottom|start, matching
portrait).
Now that fab_feedback is present in every activity_about variant, its
View Binding field is non-null, so AboutActivity uses binding.fabFeedback.root
(dropping the previous nullable ?.root) — consistent with the other screens.1 parent 3835304 commit 7f3ff75
3 files changed
Lines changed: 17 additions & 1 deletion
File tree
- app/src/main
- java/com/itsaky/androidide/activities
- res
- layout-land
- layout-sw600dp
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
121 | 129 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
121 | 129 | | |
0 commit comments