Skip to content

Conversation

nicholascioli
Copy link
Contributor

This PR updates the RMCP version to latest.

Sadly, this also means that re-exported dependencies have changed, mainly schemars being removed and also stabilized since. Since we use schemars to generate JSON schemas for operations and custom scalar maps, this meant changing a lot of unrelated filed to conform to the new API.

I've also gone ahead and split up the operations.rs file to make it more legible and easier to maintain in the future.

@nicholascioli nicholascioli requested a review from alocay September 3, 2025 17:21
@nicholascioli nicholascioli self-assigned this Sep 3, 2025
@apollo-librarian
Copy link

apollo-librarian bot commented Sep 3, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 777a569380520e00cd64f755
Build Logs: View logs

Copy link

github-actions bot commented Sep 3, 2025

Changeset file missing for PR

All changes should include an associated changeset file.
Please refer to README for more information on generating changesets.

Copy link
Contributor

@alocay alocay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets generate a canary build and hand this over to Watson

@nicholascioli nicholascioli marked this pull request as ready for review September 3, 2025 20:10
@nicholascioli nicholascioli requested a review from a team as a code owner September 3, 2025 20:10
jsonwebtoken = "9"
jwks = "0.4.0"
lz-str = "0.2.1"
regex = "1.11.1"
reqwest.workspace = true
rmcp = { version = "0.2", features = [
rmcp = { version = "0.6", features = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we pin it to an exact version like 0.6.3 to ensure reproducible builds, especially since this update required significant refactoring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cargo lock has this as 0.6.1, but I can make it more explicit here if you prefer!

Comment on lines +8 to +9

pub(super) struct Type<'a> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// A GraphQL Named Walker
pub(super) struct Name<'a> {

Do you want to add a similar comment here?

Suggested change
pub(super) struct Type<'a> {
/// A GraphQL Type Walker
pub(super) struct Type<'a> {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@apollo-librarian
Copy link

apollo-librarian bot commented Sep 5, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/config-file.mdx
* (developer-tools)/apollo-mcp-server/(latest)/index.mdx

Build ID: f6570517d81025bad8c335f4
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/f6570517d81025bad8c335f4

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some manual testing and the server feels faster to me. Is it just me? 😛

This commit updates the RMCP dependency to the latest version 0.6.1.
Sadly, schemars was also updated with this, so a lot of unrelated
changes were needed to conform with the new stable schemars version.
@nicholascioli nicholascioli merged commit 6b95db9 into develop Sep 11, 2025
10 of 11 checks passed
@nicholascioli nicholascioli deleted the nc/rmcp-update branch September 11, 2025 21:36
@apollo-bot2 apollo-bot2 mentioned this pull request Sep 12, 2025
@esilverm esilverm mentioned this pull request Sep 12, 2025
esilverm added a commit that referenced this pull request Sep 16, 2025
* fix(ci): pin to specific stable rust version (#287)

This commit pins the rust-toolchain to a specific rust version (1.89.0)
for compatibility guarantees. Renovate will handle warning on outdated
versions of stable rust.

A minimal supported rust version was also added to the underlying crates
to ensure compatibility guarantees as the stable verison increments in
future updates.

* feat: Implement Test Coverage Measurement and Reporting

* chore: add changeset

* feat: remove unnecessary codecov setting

* feat: add codecov badge

* feat: add codecov config file

* feat: add code coverage docs to CONTRIBUTING.md

* test: add tests for uplink schema event

* ci: prevent draft PRs from verifying changeset

* chore: add changeset

* ci: trigger verify changeset workflow when PR becomes ready for review

* ci: update github checkout actions

* feat: Configuration for disabling authorization token passthrough (#336)

* Allow config for not forwarding Auth tokens to GraphQL API

* use serde default to make new config optional

* Changeset

* Fix default case in main.rs

* Add new config option to documentation

* Redirect /docs/apollo-mcp-server/guides to fix 404 (#349)

Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: Michelle Mabuyo <[email protected]>

* chore: update RMCP version to latest (#328)

This commit updates the RMCP dependency to the latest version 0.6.4.
Sadly, schemars was also updated with this, so a lot of unrelated
changes were needed to conform with the new stable schemars version.

* chore(release): bumping to version 0.8.0

* chore(release): changelog for 0.8.0

---------

Co-authored-by: Apollo Bot <[email protected]>
Co-authored-by: Armando Locay <[email protected]>
Co-authored-by: Nicholas Cioli <[email protected]>
Co-authored-by: Dale Seo <[email protected]>
Co-authored-by: Dale Seo <[email protected]>
Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: apollo-bot2 <[email protected]>
Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: Michelle Mabuyo <[email protected]>
esilverm added a commit that referenced this pull request Sep 16, 2025
* Redirect /docs/apollo-mcp-server/guides to fix 404

* Fix bullet point formatting

* Add load balancer configuration details for Apollo MCP

Added instructions for configuring load balancers with Apollo MCP Server to ensure session affinity.

* Update docs/source/deploy.mdx

Co-authored-by: Michelle Mabuyo <[email protected]>

* Update deploy.mdx

* Releasing 0.8.0 (#356)

* fix(ci): pin to specific stable rust version (#287)

This commit pins the rust-toolchain to a specific rust version (1.89.0)
for compatibility guarantees. Renovate will handle warning on outdated
versions of stable rust.

A minimal supported rust version was also added to the underlying crates
to ensure compatibility guarantees as the stable verison increments in
future updates.

* feat: Implement Test Coverage Measurement and Reporting

* chore: add changeset

* feat: remove unnecessary codecov setting

* feat: add codecov badge

* feat: add codecov config file

* feat: add code coverage docs to CONTRIBUTING.md

* test: add tests for uplink schema event

* ci: prevent draft PRs from verifying changeset

* chore: add changeset

* ci: trigger verify changeset workflow when PR becomes ready for review

* ci: update github checkout actions

* feat: Configuration for disabling authorization token passthrough (#336)

* Allow config for not forwarding Auth tokens to GraphQL API

* use serde default to make new config optional

* Changeset

* Fix default case in main.rs

* Add new config option to documentation

* Redirect /docs/apollo-mcp-server/guides to fix 404 (#349)

Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: Michelle Mabuyo <[email protected]>

* chore: update RMCP version to latest (#328)

This commit updates the RMCP dependency to the latest version 0.6.4.
Sadly, schemars was also updated with this, so a lot of unrelated
changes were needed to conform with the new stable schemars version.

* chore(release): bumping to version 0.8.0

* chore(release): changelog for 0.8.0

---------

Co-authored-by: Apollo Bot <[email protected]>
Co-authored-by: Armando Locay <[email protected]>
Co-authored-by: Nicholas Cioli <[email protected]>
Co-authored-by: Dale Seo <[email protected]>
Co-authored-by: Dale Seo <[email protected]>
Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: apollo-bot2 <[email protected]>
Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: Michelle Mabuyo <[email protected]>

---------

Co-authored-by: Samuel Collard <[email protected]>
Co-authored-by: Michelle Mabuyo <[email protected]>
Co-authored-by: Alyssa Hursh <[email protected]>
Co-authored-by: Lenny Burdette <[email protected]>
Co-authored-by: Evan Silverman <[email protected]>
Co-authored-by: Armando Locay <[email protected]>
Co-authored-by: Nicholas Cioli <[email protected]>
Co-authored-by: Dale Seo <[email protected]>
Co-authored-by: Dale Seo <[email protected]>
Co-authored-by: Samuel Collard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants