Skip to content

chore: fix flaky test test_add_requests_wait_for_all #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

chore: fix flaky test test_add_requests_wait_for_all #1503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/unit/storages/test_request_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,15 +445,15 @@ async def test_add_requests_wait_for_all(
urls,
batch_size=5,
wait_for_all_requests_to_be_added=wait_for_all,
wait_time_between_batches=timedelta(milliseconds=100),
wait_time_between_batches=timedelta(milliseconds=50),
)

if not wait_for_all:
# Immediately after adding, the total count may be less than 15 due to background processing
assert await rq.get_total_count() <= 15

# Wait a 250 milliseconds for background tasks to complete
await asyncio.sleep(0.25)
# Wait a 500 milliseconds for background tasks to complete
await asyncio.sleep(0.5)

# Verify all requests were added
assert await rq.get_total_count() == 15
Expand Down
Loading