Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add playwright-based HttpClient #1128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Apr 1, 2025

Description

  • Add an asynchronous context for the HttpClient signature. This will allow correct opening and closing of resources, which is especially important for Playwright
  • Add playwright-based HttpClient with APIRequestContext

Issues

@Mantisus
Copy link
Collaborator Author

Mantisus commented Apr 1, 2025

Current Issues.

  1. What advantages do we get using APIRequestContext Playwright, compared to a pure http client?

  2. Cookie isolation. The APIRequestContext handles cookies and does not allow cookies to be set from the Session once created. Current solution, use one context per request. Cookies are set when the context is created and read into the Session after the request. What is the impact on resources and performance?

@Mantisus Mantisus self-assigned this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a playwright-based HttpClient implementation
1 participant