-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add ACTOR_PERMISSION_LEVEL to the configuration
#689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9cd910d
feat: add actor permissions to the configuration
stepskop 2457458
feat: log the actor permission on actor initialization
stepskop f2f0ca7
Revert "feat: log the actor permission on actor initialization"
stepskop a0b42d5
chore: use single alias
stepskop 7b5c3c6
chore: no need for alias as the property name is the same
stepskop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it really make sense to have multiple choices for a newly introduced variable? The aliases exist mainly for compatibility with outdated documentation 😁
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I wasn't sure how the name was inferred, so it was just to be sure 😅.
So in this case, the
actor_permission_levelshould be enough, right?The name of the env var is
ACTOR_PERMISSION_LEVELand it is part ofActorEnvVarsinapify-shared-python.https://github.com/apify/apify-shared-python/blob/782a8334e2d0e5de38aa28e10f4f1f1038497955/src/apify_shared/consts.py#L136
e.g.: I assume that it won't be prefixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we can keep just
actor_permission_leveland dropapify_actor_permission_level