-
Notifications
You must be signed in to change notification settings - Fork 139
feat: implement new images for courses #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview for this PR was built for commit |
|
Hi @honzajavorek thanks for making it happen! I'm just wondering whether it's possible to make the image stretched like this? 🙏 |
|
I tried to change dimensions of the cards, but the card component is at many places in the docs, the dimensions don't seem to be configurable, and I was afraid to break something else. I see you posted images with different dimensions - I can use those and implement them, yes! |
ad430c6 to
98aa022
Compare
|
Preview for this PR was built for commit |
|
I'll see what can I do. There seems to be a precedent, the <svg viewBox="120 145 100 100" fill="none" xmlns="http://www.w3.org/2000/svg">
<style>
path {
fill: black;
}
@media (prefers-color-scheme: dark) {
path {
fill: white;
}
}
</style>
<path d="M148.832 150.512C150.776 149.685 ..."/>
</svg>It's a simple image with one shape which has one color, so I'm not sure if it's gonna be this simple to adjust the images for the courses, but I'll see what I can do or if LLM can help. |
44eee51 to
1dd8c68
Compare
1dd8c68 to
60e601e
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
hanatsai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the effort ❤️
|
@hanatsai Thanks for designing the images! It was a nice collaboration, I think the new thumbnails actually solve a lot of issues and make the docs a much better place now - modern, in line with the brand, related to the topics of the courses, responsive to the theme… I'm really happy about it! |



Closes #1574 Thanks to @hanatsai for the designs!