-
Notifications
You must be signed in to change notification settings - Fork 130
chore: update general resource access docs #1988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
57e2bbb
chore: update pre-signed URLs docs
danpoletaev e90ba12
chore: improve docs
danpoletaev 540ca2d
chore: updated docs
danpoletaev b57d05a
fix: lint
danpoletaev 8e7188d
chore: improve docs
danpoletaev f72ff28
chore: fix lint
danpoletaev aaf5273
refactor: clean up
danpoletaev 992f083
Merge branch 'master' into chore/update-general-resource-access-docs
danpoletaev 57f3c96
refactor: clean up
danpoletaev fe6b89e
refactor: clean up
danpoletaev 30801e5
refactor: clean up
danpoletaev b89e673
Merge branch 'master' into chore/update-general-resource-access-docs
danpoletaev af5d0ff
refactor: clean up
danpoletaev 49d39ee
refactor: clean up
danpoletaev 6057eed
refactor: clean up
danpoletaev 0938857
fix lint errors
TC-MO e609827
Merge branch 'master' into chore/update-general-resource-access-docs
raethlo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+179 KB
...atform/collaboration/images/general-resouce-access/copy-record-url-kv-store.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+26.2 KB
(190%)
sources/platform/integrations/images/api-token-scoped-default-storage-access.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(general comment)
@raethlo This is essentially... you know... sharing 😄
It's just weird that we have a share modal, and then an export modal, and they both do kind of the same thing. It would totally make sense to somehow integrate it: If you want to share a storage, you should be able to generate a pre-signed link with just content from there.
I have a vague feeling that this has been already brought up somewhere... 🤔
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree completely, we may have talked about it too when I was writing the previous iteration of docs, I think from UX standpoint we should def combine export/sharing.