-
Notifications
You must be signed in to change notification settings - Fork 130
feat: added output schema docs #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview for this PR was built for commit |
Preview for this PR was built for commit |
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
Generally, it looks good. I added few comments, and here are some general comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made adjustments for clarity & style guide compliance. I also had an idea regarding structure, and perhaps it would be good to move Example section just before Advanced Examples? I know that this is different than other schema docs, but I think it makes sense to first introduce the concept, explain it, and then show example, instead of bombarding the user with example without any context
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/output_schema/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Co-authored-by: Michał Olender <[email protected]>
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Resolves: https://github.com/apify/apify-core/issues/22480
This PR adds output schema docs. I have added a few examples, but there is probably even more things that can be done with it. Will try to think of more later.